Handlers should default to LowPriorityWhenUnchanged without a wrapper

[alvaroaleman]

When we implemented the logic in the handlers to lower the priority for events where the object didn't change, we did that with a wrapper as that can be re-used.

Unfortunately, this requires everyone to remember to use this wrapper, which is extremely easy to forget:

handler.WithLowPriorityWhenUnchanged(&handler.TypedEnqueueRequestForObject[*my.CRD]{})

We should instead implement this in the handlers themselves and default to true to avoid the need for this.

[sbueringer]

/reopen

Not entirely done yet

[k8s-ci-robot]

@sbueringer: Reopened this issue.

In response to this:

/reopen

Not entirely done yet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

/reopen

@alvaroaleman Do we have to modify more handlers?

• EnqueueRequestForObject
• TypedEnqueueRequestForOwner[client.Object]

+ Should we stop wrapping the handlers with WithLowPriorityWhenUnchanged in pkg/builder/controller.go? Seems redundant

[k8s-ci-robot]

@sbueringer: Reopened this issue.

In response to this:

/reopen

@alvaroaleman Do we have to modify more handlers?

• EnqueueRequestForObject
• TypedEnqueueRequestForOwner[client.Object]

+ Should we stop wrapping the handlers with WithLowPriorityWhenUnchanged in pkg/builder/controller.go? Seems redundant

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.