Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller should retain priority by default #3157

Open
alvaroaleman opened this issue Mar 14, 2025 · 1 comment
Open

Controller should retain priority by default #3157

alvaroaleman opened this issue Mar 14, 2025 · 1 comment

Comments

@alvaroaleman
Copy link
Member

We introduced a priority queue that by default de-prioritizes events if the object was unchanged. If the object gets requeued, it will lose that priority. We should:

  • Make the controller check if the workqueue is a priority queue
  • If yes, store the priority a given key has
  • If yes, re-use that priority when calling Add, AddRatelimited or AddAfter

Related to #2374

@sbueringer
Copy link
Member

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants