Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better full duplex streaming responses handling #483

Open
kfswain opened this issue Mar 12, 2025 · 0 comments
Open

Better full duplex streaming responses handling #483

kfswain opened this issue Mar 12, 2025 · 0 comments

Comments

@kfswain
Copy link
Collaborator

kfswain commented Mar 12, 2025

What would you like to be added:
When using full duplex, we currently buffer the response if the response content-type is application/json and passthrough(stream out) when the response content-type is text/event-stream. This comment suggests allowing a flag to declare passthrough for the json path. Alternatively, since we do no modification of the body and only capture the response to capture usage metrics, we could do all buffering in a goroutine and immediately stream the response back in the main thread.
#469 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant