From bbb4816376df6aa7b41db6a003bb54eeb74c1038 Mon Sep 17 00:00:00 2001 From: Lior Lieberman Date: Thu, 30 Jan 2025 15:22:47 -0800 Subject: [PATCH 1/3] Add Gateway For Mesh section to the GEP template --- geps/gep-696/index.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/geps/gep-696/index.md b/geps/gep-696/index.md index cd401760b9..0625436f4f 100644 --- a/geps/gep-696/index.md +++ b/geps/gep-696/index.md @@ -24,9 +24,14 @@ the content into the GEP as online documents are easier to lose -- e.g. owner messes up the permissions, accidental deletion) ## API - (... details, can point to PR with changes) +### Gateway for Ingress (North/South) +(Include API details for North/South usecases) + +### Gateway For Mesh (East/West) +(Include East/West API considerations, examples, and if differnet - apis) + ## Conformance Details (from https://github.com/kubernetes-sigs/gateway-api/blob/main/geps/gep-2162/index.md#standardize-features-and-conformance-tests-names) From b8d482a0dbf50d2fb259e90ce8dd6e3f0870bdcd Mon Sep 17 00:00:00 2001 From: Lior Lieberman Date: Thu, 30 Jan 2025 15:25:50 -0800 Subject: [PATCH 2/3] Update index.md --- geps/gep-696/index.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/geps/gep-696/index.md b/geps/gep-696/index.md index 0625436f4f..80d8573dc6 100644 --- a/geps/gep-696/index.md +++ b/geps/gep-696/index.md @@ -38,6 +38,8 @@ the content into the GEP as online documents are easier to lose #### Feature Names +(Does it require seperate feature name for mesh? Please add it if necessary) + Every feature should: 1. Start with the resource name. i.e HTTPRouteXXX @@ -54,6 +56,8 @@ Treat this guidance as "best effort" because we might have test files that check In any case, the conformance tests file names should be meaningful and easy to understand. +(MAKE sure to also include conformance tests that covers mesh) + ## Alternatives (List other design alternatives and why we did not go in that From 8be214455f3bcdb06dd26dc0b7317e822584c1fe Mon Sep 17 00:00:00 2001 From: Lior Lieberman Date: Tue, 4 Feb 2025 13:13:27 -0800 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Mattia Lavacca --- geps/gep-696/index.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/geps/gep-696/index.md b/geps/gep-696/index.md index 80d8573dc6..19f4f6e978 100644 --- a/geps/gep-696/index.md +++ b/geps/gep-696/index.md @@ -30,7 +30,7 @@ the content into the GEP as online documents are easier to lose (Include API details for North/South usecases) ### Gateway For Mesh (East/West) -(Include East/West API considerations, examples, and if differnet - apis) +(Include East/West API considerations, examples, and if different - APIs) ## Conformance Details @@ -38,7 +38,7 @@ the content into the GEP as online documents are easier to lose #### Feature Names -(Does it require seperate feature name for mesh? Please add it if necessary) +(Does it require separate feature(s) for mesh? Please add them if necessary) Every feature should: @@ -56,7 +56,7 @@ Treat this guidance as "best effort" because we might have test files that check In any case, the conformance tests file names should be meaningful and easy to understand. -(MAKE sure to also include conformance tests that covers mesh) +(Make sure to also include conformance tests that cover mesh) ## Alternatives