Allow relative paths on spoc push

The file store only supports absolute paths which means that we have to
pre-calculate it before passing it in.

Signed-off-by: Sascha Grunert <[email protected]>

Author: saschagrunert

internal/pkg/artifact/artifact.go

@@ -112,8 +112,12 @@ func (a *Artifact) Push(file, to, username, password string, annotations map[str
 	defer cancel()
 
 	a.logger.Info("Adding profile to store: " + file)
+	absPath, err := a.FilepathAbs(file)
+	if err != nil {
+		return fmt.Errorf("get absoluate file path: %w", err)
+	}
 	fileDescriptor, err := a.StoreAdd(
-		ctx, store, defaultProfileYAML, "", file,
+		ctx, store, defaultProfileYAML, "", absPath,
 	)
 	if err != nil {
 		return fmt.Errorf("add profile to store: %w", err)

internal/pkg/artifact/artifact_test.go

@@ -134,6 +134,15 @@ func TestPush(t *testing.T) {
 				require.ErrorIs(t, err, errTest)
 			},
 		},
+		{
+			name: "failure on FilepathAbs",
+			prepare: func(mock *artifactfakes.FakeImpl) {
+				mock.FilepathAbsReturns("", errTest)
+			},
+			assert: func(err error) {
+				require.ErrorIs(t, err, errTest)
+			},
+		},
 		{
 			name: "failure on StoreAdd",
 			prepare: func(mock *artifactfakes.FakeImpl) {

internal/pkg/artifact/artifactfakes/fake_impl.go

@@ -19,6 +19,7 @@ package artifact
 import (
 	"context"
 	"os"
+	"path/filepath"
 
 	ggcrname "github.com/google/go-containerregistry/pkg/name"
 	ocispec "github.com/opencontainers/image-spec/specs-go/v1"
@@ -42,6 +43,7 @@ type impl interface {
 	RemoveAll(string) error
 	FileNew(string) (*file.Store, error)
 	FileClose(*file.Store) error
+	FilepathAbs(string) (string, error)
 	NewRepository(string) (*remote.Repository, error)
 	Copy(context.Context, oras.ReadOnlyTarget, string, oras.Target, string, oras.CopyOptions) (ocispec.Descriptor, error)
 	ReadFile(string) ([]byte, error)
@@ -74,6 +76,10 @@ func (*defaultImpl) FileClose(store *file.Store) error {
 	return store.Close()
 }
 
+func (*defaultImpl) FilepathAbs(path string) (string, error) {
+	return filepath.Abs(path)
+}
+
 func (*defaultImpl) NewRepository(reference string) (*remote.Repository, error) {
 	return remote.NewRepository(reference)
 }