Skip to content

Commit 9047626

Browse files
fix release github action
Signed-off-by: Xudong Liu <[email protected]>
1 parent d76ab69 commit 9047626

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

.github/workflows/generate-release-notes.yml

+20-15
Original file line numberDiff line numberDiff line change
@@ -38,38 +38,43 @@ jobs:
3838
run: |
3939
git fetch --tags --force
4040
latest_tag=$(git tag --sort=-creatordate | head -n 1)
41-
41+
echo "latest release is ${latest_tag}"
4242
echo "latest_tag=${latest_tag}" >> $GITHUB_OUTPUT
43-
echo "valid=$(./hack/match-release-tag.sh ${latest_tag} >/dev/null 2>&1)" >> $GITHUB_OUTPUT
43+
44+
./hack/match-release-tag.sh ${latest_tag}
45+
valid=$?
46+
echo "valid release: ${valid}"
47+
echo "valid=${valid}" >> $GITHUB_OUTPUT
4448
4549
- name: Find Second Latest Release Tag
46-
if: ${{ steps.check.outputs.valid }}
50+
if: ${{ steps.check.outputs.valid }} == 0
4751
id: find
4852
run: |
4953
SEMVER_REGEX='^[[:space:]]{0,}v[[:digit:]]{1,}\.[[:digit:]]{1,}\.[[:digit:]]{1,}(-(alpha|beta|rc)\.[[:digit:]]{1,}){0,1}[[:space:]]{0,}$'
5054
PRERELEASE_SEMVER_REGEX='^v?[0-9]+\.[0-9]+\.[0-9]+-[0-9A-Za-z-]+(\.[0-9A-Za-z-]+)*$'
5155
STABLE_RELEASE_SEMVER_REGEX='^v?[0-9]+\.[0-9]+\.[0-9]+$'
5256
5357
latest_tag=${{ steps.check.outputs.latest_tag }}
58+
5459
if [[ latest_tag =~ ${PRERELEASE_SEMVER_REGEX} ]]; then
55-
second_latest_release_tag=$(git tag --sort=-v:refname | grep -E ${SEMVER_REGEX} | awk 'p{print; exit} /${latest_tag}/{p=1}')
60+
second_latest_release_tag=$(git tag --sort=-v:refname | grep -E ${SEMVER_REGEX} | awk "p{print; exit} /${latest_tag}/{p=1}")
5661
echo "${latest_tag} is a pre-release, return second latest release tag ${second_latest_release_tag}"
5762
echo "pre_release=1" >> $GITHUB_OUTPUT
5863
else
59-
second_latest_release_tag=$(git tag --sort=-v:refname | grep -E ${STABLE_RELEASE_SEMVER_REGEX} | awk 'p{print; exit} /${latest_tag}/{p=1}')
64+
second_latest_release_tag=$(git tag --sort=-v:refname | grep -E ${STABLE_RELEASE_SEMVER_REGEX} | awk "p{print; exit} /${latest_tag}/{p=1}")
6065
echo "${latest_tag} is a stable release, return second stable release tag ${second_latest_release_tag}"
6166
fi
6267
6368
echo "second_latest_release_tag=${second_latest_release_tag}" >> $GITHUB_OUTPUT
6469
6570
66-
- name: Generate Release Note
67-
if: ${{ steps.check.outputs.valid }}
68-
run: |
69-
if ${{ steps.find.outputs.pre_release}} >/dev/null 2>&1; then
70-
gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }} --prerelease
71-
else
72-
gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }}
73-
fi
74-
env:
75-
GH_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
71+
# - name: Generate Release Note
72+
# if: ${{ steps.check.outputs.valid }} == 0
73+
# run: |
74+
# if ${{ steps.find.outputs.pre_release}} >/dev/null 2>&1; then
75+
# gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }} --prerelease
76+
# else
77+
# gh release create ${{ steps.check.outputs.latest_tag }} --verify-tag --generate-notes --notes-start-tag ${{ steps.find.outputs.second_latest_release_tag }}
78+
# fi
79+
# env:
80+
# GH_TOKEN: "${{ secrets.GITHUB_TOKEN }}"

hack/match-release-tag.sh

+3
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,13 @@ REGEX='^[[:space:]]{0,}v[[:digit:]]{1,}\.[[:digit:]]{1,}\.[[:digit:]]{1,}(-(alph
6565
# Match the tag against the regular expression for a release tag.
6666
match() {
6767
if [[ ${1} =~ ${REGEX} ]]; then
68+
exit_code="${?}"
6869
echo "yay: ${1}"
70+
echo "${exit_code}"
6971
else
7072
exit_code="${?}"
7173
echo "nay: ${1}"
74+
echo "${exit_code}"
7275
return "${exit_code}"
7376
fi
7477
}

0 commit comments

Comments
 (0)