Skip to content

Commit 186c66f

Browse files
mcmxcdevkinyoklion
andauthored
chore: remove deprecated tslint dependency (#323)
**Requirements** - [ ] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [ ] I have validated my changes against all supported platform versions **Changes** - remove `tslint` dependency from root `package.json` - remove `tslint-disable-next-line` statements from various files - add `pnpm-lock.yaml` and `pnpm-debug.log` files to `.gitignore` **Related issues** When running dependency installation with e.g. `pnpm` in this repository, I encountered the following warning: ```  WARN  deprecated [email protected]: TSLint has been deprecated in favor of ESLint. Please see palantir/tslint#4534 for more information. ``` The migration from `tslint` to `eslint` was done in #297, but it seems that the `tslint` dependency has not been removed as part of it. --------- Co-authored-by: Ryan Lamb <[email protected]>
1 parent a8b52f4 commit 186c66f

File tree

5 files changed

+3
-5
lines changed

5 files changed

+3
-5
lines changed

.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
**/junit.xml
44
npm-debug.log
55
yarn-error.log
6+
pnpm-debug.log
67
node_modules
78
dist
89
lib
@@ -12,5 +13,6 @@ test-types.js
1213
docs/build/
1314
yarn.lock
1415
package-lock.json
16+
pnpm-lock.yaml
1517
.npmrc
1618
docs/

examples/deferred-initialization/src/App.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import logo from './logo.svg';
33
import Welcome from './welcome';
44
import { LDProvider, LDContext } from 'launchdarkly-react-client-sdk';
55

6-
// tslint:disable-next-line:no-import-side-effect
76
import './App.css';
87

98
const clientSideID = process.env.REACT_APP_LD_CLIENT_SIDE_ID ?? '';

examples/deferred-initialization/src/index.tsx

-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
import React from 'react';
2-
// tslint:disable-next-line:no-submodule-imports
32
import ReactDOM from 'react-dom/client';
43
import App from './App';
54
import reportWebVitals from './reportWebVitals';
65

7-
// tslint:disable-next-line:no-import-side-effect
86
import './index.css';
97

108
const root = ReactDOM.createRoot(document.getElementById('root') as HTMLElement);

examples/deferred-initialization/src/welcome.tsx

-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import React from 'react';
22
import { useFlags } from 'launchdarkly-react-client-sdk';
33

4-
// tslint:disable-next-line:no-import-side-effect
54
import './App.css';
65

76
function Welcome() {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"rollup-plugin-dts": "^6.1.0",
7979
"rollup-plugin-esbuild": "^6.1.1",
8080
"ts-jest": "^29.2.2",
81-
"tslint": "^6.1.3",
81+
"tslib": "^2.8.1",
8282
"typedoc": "^0.26.5",
8383
"typescript": "^5.5.4",
8484
"typescript-eslint": "^8.0.0"

0 commit comments

Comments
 (0)