refactor: ♻️ refactor problem details exception handler

Author: mehdihadeli

.config/dotnet-tools.json

@@ -31,7 +31,7 @@
       "rollForward": false
     },
     "dotnet-ef": {
-      "version": "8.0.7",
+      "version": "8.0.8",
       "commands": [
         "dotnet-ef"
       ],

.github/release-drafter.yml

@@ -15,46 +15,49 @@ template: |
   $CHANGES
   **Full Changelog**: https://github.com/$OWNER/$REPOSITORY/compare/$PREVIOUS_TAG...v$RESOLVED_VERSION
 categories:
-  - title: 🚀 Features
-    labels:
-      - feature
-  - title: ♻️ Enhancement
-    labels:
-      - enhancement
-      - refactor
-  - title: 🐛 Bug Fixes
-    labels:
-      - fix
-      - bug
-  - title: 👷 CI
-    labels:
-      - ci
-  - title: ⚠️ Breaking Changes
-    labels:
-      - breaking-changes
-  - title: ⛔️ Deprecated
-    labels:
-      - deprecated
-  - title: 🗑 Removed
-    labels:
-      - removed
-  - title: 🔐 Security
-    labels:
-      - security
-  - title: 📄 Documentation
-    labels:
-      - docs
-      - documentation
-  - title: 🧩 Dependency Updates
-    labels:
-      - deps
-      - dependencies
-  - title: 🧰 Maintenance
-    label: 'chore'
-  - title: 🧺 Miscellaneous #Everything except ABAP
-    label: misc
-  - title: 🚩 Other changes
-## putting no labels pr to `Other Changes` category with no label - https://github.com/release-drafter/release-drafter/issues/139#issuecomment-480473934
+- title: 🚀 Features
+  labels:
+  - feature
+- title: ♻️ Enhancement
+  labels:
+  - enhancement
+  - refactor
+- title: 🐛 Bug Fixes
+  labels:
+  - fix
+  - bug
+- title: 👷 CI
+  labels:
+  - ci
+- title: 🧪 Test
+  labels:
+  - test
+- title: ⚠️ Breaking Changes
+  labels:
+  - breaking-changes
+- title: ⛔️ Deprecated
+  labels:
+  - deprecated
+- title: 🗑 Removed
+  labels:
+  - removed
+- title: 🔐 Security
+  labels:
+  - security
+- title: 📄 Documentation
+  labels:
+  - docs
+  - documentation
+- title: 🧩 Dependency Updates
+  labels:
+  - deps
+  - dependencies
+- title: 🧰 Maintenance
+  label: 'chore'
+- title: 🧺 Miscellaneous #Everything except ABAP
+  label: misc
+- title: 🚩 Other changes
+  ## putting no labels pr to `Other Changes` category with no label - https://github.com/release-drafter/release-drafter/issues/139#issuecomment-480473934
 
 
 # https://www.trywilco.com/post/wilco-ci-cd-github-heroku
@@ -64,52 +67,62 @@ categories:
 # Using regex for defining rules - https://regexr.com/
 # https://stackoverflow.com/questions/58899999/regexp-to-match-conventional-commit-syntax
 autolabeler:
-  - label: 'chore'
-    branch:
-      - '(chore)(\([a-z ]+\))?\/.'
-    title:
-      - '^(chore)(\([a-z ]+\))?: .'
-  - label: 'bug'
-    branch:
-      - '(fix)(\([a-z ]+\))?\/.'
-    title:
-      - '^(fix)(\([a-z ]+\))?: .'
-  - label: 'feature'
-    branch:
-      - '(feat)(\([a-z ]+\))?\/.'
-    title:
-      - '^(feat)(\([a-z ]+\))?: .'
-  - label: 'ci/cd'
-    branch:
-      - '(ci)(\([a-z ]+\))?\/.'
-    title:
-      - '^(ci)(\([a-z ]+\))?: .'
-  - label: 'minor'
-    branch:
-      - '(feat)(\([a-z ]+\))?\/.'
-    title:
-      - '^(feat)(\([a-z ]+\))?: .'
-  - label: 'patch'
-    branch:
-      - '(fix)(\([a-z ]+\))?\/.'
-      - '(ci)(\([a-z ]+\))?\/.'
-    title:
-      - '^(fix)(\([a-z ]+\))?: .'
-      - '^(ci)(\([a-z ]+\))?: .'
+- label: 'chore'
+  branch:
+  - '(chore)(\([a-z ]+\))?\/.'
+  title:
+  - '^(chore)(\([a-z ]+\))?: .'
+- label: 'bug'
+  branch:
+  - '(fix)(\([a-z ]+\))?\/.'
+  title:
+  - '^(fix)(\([a-z ]+\))?: .'
+- label: 'refactor'
+  branch:
+  - '(refactor)(\([a-z ]+\))?\/.'
+  title:
+  - '^(refactor)(\([a-z ]+\))?: .'
+- label: 'test'
+  branch:
+  - '(test)(\([a-z ]+\))?\/.'
+  title:
+  - '^(test)(\([a-z ]+\))?: .'
+- label: 'feature'
+  branch:
+  - '(feat)(\([a-z ]+\))?\/.'
+  title:
+  - '^(feat)(\([a-z ]+\))?: .'
+- label: 'ci/cd'
+  branch:
+  - '(ci)(\([a-z ]+\))?\/.'
+  title:
+  - '^(ci)(\([a-z ]+\))?: .'
+- label: 'minor'
+  branch:
+  - '(feat)(\([a-z ]+\))?\/.'
+  title:
+  - '^(feat)(\([a-z ]+\))?: .'
+- label: 'patch'
+  branch:
+  - '(fix)(\([a-z ]+\))?\/.'
+  - '(ci)(\([a-z ]+\))?\/.'
+  title:
+  - '^(fix)(\([a-z ]+\))?: .'
+  - '^(ci)(\([a-z ]+\))?: .'
 
 change-template: '- $TITLE @$AUTHOR (#$NUMBER)'
 change-title-escapes: '\<*_&' # You can add # and @ to disable mentions, and add ` to disable code blocks.
 version-resolver:
   major:
     labels:
-      - breaking-changes
+    - breaking-changes
   minor:
     labels:
-      - minor
+    - minor
   patch:
     labels:
-      - patch
+    - patch
   default: patch
 
 exclude-labels:
-  - skip-changelog
+- skip-changelog

package.json

@@ -4,7 +4,8 @@
   "description": "food-delivery-microservices",
   "scripts": {
     "prepare": "husky && dotnet tool restore",
-    "install-dev-cert-bash": "curl -sSL https://aka.ms/getvsdbgsh | bash /dev/stdin -v vs2019 -l ~/vsdbg"
+    "install-dev-cert-bash": "curl -sSL https://aka.ms/getvsdbgsh | bash /dev/stdin -v vs2019 -l ~/vsdbg",
+	"upgrade-packages": "dotnet outdated food-delivery-microservices.sln"
   },
   "repository": {
     "type": "git",

src/BuildingBlocks/BuildingBlocks.Core/Exception/Types/InvalidAddressException.cs

@@ -4,9 +4,9 @@ namespace BuildingBlocks.Core.Web.Extensions;
 
 public static class HostEnvironmentExtensions
 {
-    public static bool IsTest(this IHostEnvironment env) => env.IsEnvironment("Test");
+    public static bool IsTest(this IHostEnvironment env) => env.IsEnvironment(Environments.Test);
 
-    public static bool IsDependencyTest(this IHostEnvironment env) => env.IsEnvironment("DependencyTest");
+    public static bool IsDependencyTest(this IHostEnvironment env) => env.IsEnvironment(Environments.DependencyTest);
 
-    public static bool IsDocker(this IHostEnvironment env) => env.IsEnvironment("Docker");
+    public static bool IsDocker(this IHostEnvironment env) => env.IsEnvironment(Environments.Docker);
 }

src/BuildingBlocks/BuildingBlocks.Core/Exception/Types/InvalidAmountException.cs

@@ -31,13 +31,16 @@
     <PackageReference Include="AspNetCore.HealthChecks.Rabbitmq" />
     <PackageReference Include="AspNetCore.HealthChecks.NpgSql" />
     <PackageReference Include="AspNetCore.HealthChecks.EventStore" />
+    <PackageReference Include="prometheus-net.AspNetCore" />
+    <PackageReference Include="prometheus-net.AspNetCore.Grpc" />
+    <PackageReference Include="prometheus-net.AspNetCore.HealthChecks" />
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" />
     <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore" />
-    <PackageReference Include="prometheus-net.AspNetCore" />
-    <PackageReference Include="prometheus-net.AspNetCore.Grpc" />
-    <PackageReference Include="prometheus-net.AspNetCore.HealthChecks" />
+    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks.ResourceUtilization" />
+
   </ItemGroup>
 
 </Project>

src/BuildingBlocks/BuildingBlocks.Core/Exception/Types/InvalidCurrencyException.cs

@@ -19,6 +19,8 @@ namespace BuildingBlocks.HealthCheck;
 // https://github.com/prometheus-net/prometheus-net
 public static class DependencyInjectionExtensions
 {
+    private static readonly string[] _defaultTags = ["live", "ready",];
+
     public static WebApplicationBuilder AddCustomHealthCheck(
         this WebApplicationBuilder builder,
         Action<IHealthChecksBuilder>? healthChecksBuilder = null,
@@ -38,10 +40,24 @@ public static WebApplicationBuilder AddCustomHealthCheck(
 
         var healCheckBuilder = builder
             .Services.AddHealthChecks()
-            .AddDiskStorageHealthCheck(_ => { }, tags: new[] { "live", "ready" })
-            .AddPingHealthCheck(_ => { }, tags: new[] { "live", "ready" })
-            .AddPrivateMemoryHealthCheck(512 * 1024 * 1024, tags: new[] { "live", "ready" })
-            .AddDnsResolveHealthCheck(_ => { }, tags: new[] { "live", "ready" })
+            .AddDiskStorageHealthCheck(_ => { }, tags: _defaultTags)
+            .AddPingHealthCheck(_ => { }, tags: _defaultTags)
+            .AddPrivateMemoryHealthCheck(512 * 1024 * 1024, tags: _defaultTags)
+            .AddDnsResolveHealthCheck(_ => { }, tags: _defaultTags)
+            .AddResourceUtilizationHealthCheck(o =>
+            {
+                o.CpuThresholds = new ResourceUsageThresholds
+                {
+                    DegradedUtilizationPercentage = 80,
+                    UnhealthyUtilizationPercentage = 90,
+                };
+                o.MemoryThresholds = new ResourceUsageThresholds
+                {
+                    DegradedUtilizationPercentage = 80,
+                    UnhealthyUtilizationPercentage = 90,
+                };
+                o.SamplingWindow = TimeSpan.FromSeconds(5);
+            })
             .ForwardToPrometheus();
 
         healthChecksBuilder?.Invoke(healCheckBuilder);

src/BuildingBlocks/BuildingBlocks.Core/Exception/Types/InvalidDateException.cs

@@ -9,6 +9,7 @@
 using BuildingBlocks.Core.Messaging;
 using BuildingBlocks.Core.Reflection;
 using BuildingBlocks.Core.Reflection.Extensions;
+using BuildingBlocks.Core.Web.Extensions;
 using Humanizer;
 using MassTransit;
 using Microsoft.AspNetCore.Builder;
@@ -49,7 +50,7 @@ params Assembly[] scanAssemblies
                 ? scanAssemblies
                 : ReflectionUtilities.GetReferencedAssemblies(Assembly.GetCallingAssembly()).ToArray();
 
-        if (!builder.Environment.IsEnvironment("test"))
+        if (!builder.Environment.IsTest())
         {
             builder.Services.AddMassTransit(ConfiguratorAction);
         }

src/BuildingBlocks/BuildingBlocks.Core/Exception/Types/InvalidEmailException.cs

@@ -1,4 +1,5 @@
 using BuildingBlocks.Core.Persistence.EfCore;
+using BuildingBlocks.Core.Web;
 using Microsoft.EntityFrameworkCore;
 using Microsoft.EntityFrameworkCore.Design;
 using Microsoft.EntityFrameworkCore.Storage.ValueConversion;
@@ -14,7 +15,7 @@ public TDbContext CreateDbContext(string[] args)
     {
         Console.WriteLine($"BaseDirectory: {AppContext.BaseDirectory}");
 
-        var environmentName = env ?? Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT") ?? "test";
+        var environmentName = env ?? Environment.GetEnvironmentVariable("ASPNETCORE_ENVIRONMENT") ?? Environments.Test;
 
         var builder = new ConfigurationBuilder()
             .SetBasePath(AppContext.BaseDirectory ?? "")

src/BuildingBlocks/BuildingBlocks.Core/Exception/Types/InvalidPhoneNumberException.cs

@@ -20,7 +20,12 @@ public static async Task<TRequest> HandleValidationAsync<TRequest>(
     {
         var validationResult = await validator.ValidateAsync(request, cancellationToken).ConfigureAwait(false);
         if (!validationResult.IsValid)
-            throw new ValidationException(validationResult.ToValidationResultModel().Message);
+        {
+            throw new ValidationException(
+                validationResult.ToValidationResultModel().Errors?.FirstOrDefault()?.Message
+                    ?? validationResult.ToValidationResultModel().Message
+            );
+        }
 
         return request;
     }
@@ -29,7 +34,12 @@ public static TRequest HandleValidation<TRequest>(this IValidator<TRequest> vali
     {
         var validationResult = validator.Validate(request);
         if (!validationResult.IsValid)
-            throw new ValidationException(validationResult.ToValidationResultModel().Message);
+        {
+            throw new ValidationException(
+                validationResult.ToValidationResultModel().Errors?.FirstOrDefault()?.Message
+                    ?? validationResult.ToValidationResultModel().Message
+            );
+        }
 
         return request;
     }