Skip to content

Commit cbb7831

Browse files
committed
Address review points
1 parent 879c07b commit cbb7831

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

proposals/NNNN-debug-printf.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,13 @@ will be a variable arguments function.
6565

6666
## Detailed design
6767

68-
1. The printf dxil op will be non-semantic, it does not affect final hlsl code/algorithm.
69-
Non-semantic dxil op code can be counted down from 0xffff, or 0xffffffff, it will give a hint to the client api
70-
to remove the non semantic dxil safely
68+
1. The printf dxil op will be purely for debug purpose, it does not affect final hlsl
69+
code/algorithm in any way.
70+
To separate this kind of debug-purpose dxil ops to the normal non-debug dxil il ops,
71+
the debug printf dxil op code can be counted down from 0xffff, or 0xffffffff,
72+
e.g. op code is 0xfffe.
73+
So it will give a hint to the d3d debug layer to pick up debug printf dxil easily,
74+
or a underlying d3d driver to remove these dxil op codes safely.
7175
2. Add a option to enable printf dxil op generation to dxc, try to separate hlsl code for debugging
7276
and for production, if printf option is disabled, the printf in hlsl will be report a error
7377
3. We should not support dynamic string variable, a string variable content.
@@ -79,4 +83,4 @@ expression, we need to retrieve global variable from the constant expression.
7983
of printf variable arguments, there is no definite function type can be validated.
8084
6. dxc does not valiate format specifier to the c/c++ format speicifer standard, or the matching relation between
8185
format specifier and argument. If the number and type don't match, they will produce undefined result from
82-
client api, e.g. driver.
86+
a underlying d3d driver or a debug driver

0 commit comments

Comments
 (0)