Skip to content

Commit 1569b3b

Browse files
committed
docs: fix static check errors
Somehow we are not running static checks for a long time. And that ended up with a lot for errors. * Ensure debug options are valid is dropped * fix snap links * drop extra CONTRIBUTING.md * reference kata-pkgsync * move CODEOWNERS to proper place * remove extra CODE_OF_CONDUCT.md. * fix spell checker error on Developer-Guide.md Signed-off-by: Peng Tao <[email protected]>
1 parent df3119b commit 1569b3b

File tree

12 files changed

+19
-35
lines changed

12 files changed

+19
-35
lines changed

docs/CODEOWNERS CODEOWNERS

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2019 Intel Corporation.
1+
# Copyright (c) 2019 Intel Corporation
22
#
33
# SPDX-License-Identifier: Apache-2.0
44
#
@@ -10,4 +10,3 @@
1010
# used. See https://help.github.com/articles/about-code-owners/
1111

1212
*.md @kata-containers/documentation
13-

docs/CODE_OF_CONDUCT.md

-3
This file was deleted.

docs/CONTRIBUTING.md

-5
This file was deleted.

docs/Developer-Guide.md

+5-7
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,13 @@
3939
* [Enable agent debug console](#enable-agent-debug-console)
4040
* [Start `kata-monitor`](#start-kata-monitor)
4141
* [Connect to debug console](#connect-to-debug-console)
42-
* [Traditional debug console setup](#traditional-simple-debug-console-setup)
42+
* [Traditional debug console setup](#traditional-debug-console-setup)
4343
* [Create a custom image containing a shell](#create-a-custom-image-containing-a-shell)
4444
* [Create a debug systemd service](#create-a-debug-systemd-service)
4545
* [Build the debug image](#build-the-debug-image)
4646
* [Configure runtime for custom debug image](#configure-runtime-for-custom-debug-image)
47-
* [Ensure debug options are valid](#ensure-debug-options-are-valid)
4847
* [Create a container](#create-a-container)
4948
* [Connect to the virtual machine using the debug console](#connect-to-the-virtual-machine-using-the-debug-console)
50-
* [Obtain details of the image](#obtain-details-of-the-image)
5149
* [Capturing kernel boot logs](#capturing-kernel-boot-logs)
5250

5351
# Warning
@@ -450,7 +448,7 @@ contain either `/bin/sh` or `/bin/bash`.
450448

451449
#### Enable agent debug console
452450

453-
Enable debug_console_enabled in the configuration.toml configuration file:
451+
Enable debug_console_enabled in the `configuration.toml` configuration file:
454452

455453
```
456454
[agent.kata]
@@ -461,7 +459,7 @@ This will pass `agent.debug_console agent.debug_console_vport=1026` to agent as
461459

462460
#### Start `kata-monitor`
463461

464-
The `kata-runtime exec` command needs `kata-monitor` to get the sandbox's `vsock` address to connect to, firt start `kata-monitor`.
462+
The `kata-runtime exec` command needs `kata-monitor` to get the sandbox's `vsock` address to connect to, first start `kata-monitor`.
465463

466464
```
467465
$ sudo kata-monitor
@@ -503,7 +501,7 @@ the following steps (using rootfs or initrd image).
503501
>
504502
> Look for `INIT_PROCESS=systemd` in the `config.sh` osbuilder rootfs config file
505503
> to verify an osbuilder distro supports systemd for the distro you want to build rootfs for.
506-
> For an example, see the [Clear Linux config.sh file](../tools/osbuilder/blob/master/rootfs-builder/clearlinux/config.sh).
504+
> For an example, see the [Clear Linux config.sh file](../tools/osbuilder/rootfs-builder/clearlinux/config.sh).
507505
>
508506
> For a non-systemd-based distro, create an equivalent system
509507
> service using that distro’s init system syntax. Alternatively, you can build a distro
@@ -589,7 +587,7 @@ to avoid all subsequently created containers from using the debug image.
589587

590588
#### Create a container
591589

592-
Create a container as normal. For example using crictl:
590+
Create a container as normal. For example using `crictl`:
593591

594592
```
595593
$ sudo crictl run -r kata container.yaml pod.yaml

docs/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ Documents that help to understand and contribute to Kata Containers.
5454

5555
* [Developer Guide](Developer-Guide.md): Setup the Kata Containers developing environments
5656
* [How to contribute to Kata Containers](https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md)
57-
* [Code of Conduct](CODE_OF_CONDUCT.md)
57+
* [Code of Conduct](../CODE_OF_CONDUCT.md)
5858

5959
### Code Licensing
6060

snap/README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -84,12 +84,12 @@ then a new configuration file can be [created](#configure-kata-containers)
8484
and [configured][7].
8585

8686
[1]: https://docs.snapcraft.io/snaps/intro
87-
[2]: ../../../docs/design/architecture.md#root-filesystem-image
87+
[2]: ../docs/design/architecture.md#root-filesystem-image
8888
[3]: https://docs.snapcraft.io/reference/confinement#classic
8989
[4]: https://github.com/kata-containers/runtime#configuration
9090
[5]: https://docs.docker.com/engine/reference/commandline/dockerd
91-
[6]: ../../../docs/install/docker/ubuntu-docker-install.md
92-
[7]: ../../../docs/Developer-Guide.md#configure-to-use-initrd-or-rootfs-image
91+
[6]: ../docs/install/docker/ubuntu-docker-install.md
92+
[7]: ../docs/Developer-Guide.md#configure-to-use-initrd-or-rootfs-image
9393
[8]: https://snapcraft.io/kata-containers
94-
[9]: ../../../docs/Developer-Guide.md#run-kata-containers-with-docker
95-
[10]: ../../../docs/Developer-Guide.md#run-kata-containers-with-kubernetes
94+
[9]: ../docs/Developer-Guide.md#run-kata-containers-with-docker
95+
[10]: ../docs/Developer-Guide.md#run-kata-containers-with-kubernetes

src/runtime/CONTRIBUTING.md

-5
This file was deleted.

src/runtime/virtcontainers/documentation/Developers.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,5 +51,5 @@ This will:
5151
# Submitting changes
5252

5353
For details on the format and how to submit changes, refer to the
54-
[Contributing](../../CONTRIBUTING.md) document.
54+
[Contributing](../../../../CONTRIBUTING.md) document.
5555

src/runtime/virtcontainers/pkg/agent/protocols/client/client.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2017 HyperHQ Inc.
1+
// Copyright (c) 2017 HyperHQ Inc.
22
//
33
// SPDX-License-Identifier: Apache-2.0
44
//

tools/packaging/CODE_OF_CONDUCT.md

-3
This file was deleted.

tools/packaging/CONTRIBUTING.md

-1
This file was deleted.

tools/packaging/README.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ running Kubernetes Cluster very straightforward.
3131

3232
## Build a snap package
3333

34-
See [the snap documentation](snap).
34+
See [the snap documentation](../../snap).
3535

3636
## Build static binaries
3737

@@ -61,6 +61,10 @@ See [the Jenkins documentation](Jenkinsfiles).
6161

6262
See the [scripts documentation](scripts).
6363

64+
## Sync packages
65+
66+
See [the `kata-pkgsync` documentation](cmd/kata-pkgsync).
67+
6468
## Credits
6569

6670
Kata Containers packaging uses [packagecloud](https://packagecloud.io) for

0 commit comments

Comments
 (0)