Skip to content

Commit 15aef18

Browse files
committed
Remove full-icu
full-icu is the default as of Node v13. I tested `Number.prototype.toLocaleString` against the nodejs_16.1.0-deb-1nodesource1_amd64.deb package to verify that localization works out of the box. Reverts the following commits: 96e4a95 2c9f9d2
1 parent b9ff252 commit 15aef18

File tree

4 files changed

+2
-9
lines changed

4 files changed

+2
-9
lines changed

docker/scripts/start_template_renderer.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ MBS_ROOT=$MBS_HOME/musicbrainz-server
77

88
cd "$MBS_ROOT"
99

10-
exec sudo -E -H -u musicbrainz node --icu-data-dir=node_modules/full-icu root/server.js
10+
exec sudo -E -H -u musicbrainz node root/server.js

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
"detect-node": "2.0.3",
3535
"file-loader": "3.0.1",
3636
"filesize": "2.0.4",
37-
"full-icu": "1.3.1",
3837
"generic-diff": "1.0.1",
3938
"he": "1.1.1",
4039
"imports-loader": "0.8.0",

script/start_renderer.pl

+1-2
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,5 @@
4343
push @argv, ('--socket', $socket) if $socket;
4444
push @argv, ('--workers', $workers) if $workers;
4545
chdir qq($FindBin::Bin/../);
46-
# If updating to a min. req. of Node 13+, check if icu-data-dir is still needed
47-
exec 'node', '--icu-data-dir=node_modules/full-icu', 'root/server.js', @argv;
46+
exec 'node', 'root/server.js', @argv;
4847
}

yarn.lock

-5
Original file line numberDiff line numberDiff line change
@@ -3380,11 +3380,6 @@ fsevents@^1.2.7:
33803380
bindings "^1.5.0"
33813381
nan "^2.12.1"
33823382

3383-
3384-
version "1.3.1"
3385-
resolved "https://registry.yarnpkg.com/full-icu/-/full-icu-1.3.1.tgz#e67fdf58523f1d1e0d9143b1542fe2024c1c8997"
3386-
integrity sha512-VMtK//85QJomhk3cXOCksNwOYaw1KWnYTS37GYGgyf7A3ajdBoPGhaJuJWAH2S2kq8GZeXkdKn+3Mfmgy11cVw==
3387-
33883383
function-bind@^1.0.2, function-bind@^1.1.1, function-bind@~1.1.0:
33893384
version "1.1.1"
33903385
resolved "https://registry.yarnpkg.com/function-bind/-/function-bind-1.1.1.tgz#a56899d3ea3c9bab874bb9773b7c5ede92f4895d"

0 commit comments

Comments
 (0)