Remove .js from manifest.js paths

When migrating to Webpack v5, we'll be generating rev-manifest.json from
the Webpack stats object, which doesn't include .js in the asset name
keys.

Author: mwiencek

lib/MusicBrainz/Server/Data/FileCache.pm

@@ -79,6 +79,7 @@ sub path_to {
     my ($self, $manifest) = @_;
 
     $manifest =~ s/^\///;
+    $manifest =~ s/\.js(on)?$//;
     return DBDefs->STATIC_RESOURCES_LOCATION . '/' .
         ($self->manifest_signature($manifest) // $manifest);
 }

root/account/applications/Register.js

@@ -28,7 +28,7 @@ const RegisterApplication = (props: Props): React.Element<typeof Layout> => (
       form={props.form}
       submitLabel={l('Register')}
     />
-    {manifest.js('account/applications/register.js', {async: 'async'})}
+    {manifest.js('account/applications/register', {async: 'async'})}
   </Layout>
 );
 

root/area/AreaIndex.js

@@ -40,7 +40,7 @@ const AreaIndex = ({
       entity={area}
     />
     <Relationships source={area} />
-    {manifest.js('area/index.js', {async: 'async'})}
+    {manifest.js('area/index', {async: 'async'})}
   </AreaLayout>
 );
 

root/area/AreaPlaces.js

@@ -40,7 +40,7 @@ const AreaPlaces = ({
         {DBDefs.MAPBOX_ACCESS_TOKEN ? (
           <>
             <div id="largemap" />
-            {manifest.js('area/places-map.js', {'data-args': mapDataArgs})}
+            {manifest.js('area/places-map', {'data-args': mapDataArgs})}
           </>
         ) : (
           <p>

root/artist/ArtistIndex.js

@@ -339,7 +339,7 @@ const ArtistIndex = ({
         />
       )}
 
-      {manifest.js('artist/index.js', {async: 'async'})}
+      {manifest.js('artist/index', {async: 'async'})}
     </ArtistLayout>
   );
 };

root/event/EventIndex.js

@@ -58,7 +58,7 @@ const EventIndex = ({
           </p>
         </>
       ) : null}
-      {manifest.js('event/index.js', {async: 'async'})}
+      {manifest.js('event/index', {async: 'async'})}
     </EventLayout>
   );
 };

root/instrument/InstrumentIndex.js

@@ -51,7 +51,7 @@ const InstrumentIndex = ({
       entity={instrument}
     />
     <Relationships source={instrument} />
-    {manifest.js('instrument/index.js', {async: 'async'})}
+    {manifest.js('instrument/index', {async: 'async'})}
   </InstrumentLayout>
 );
 

root/label/LabelIndex.js

@@ -77,7 +77,7 @@ const LabelIndex = ({
     ) : (
       <p>{l('This label does not have any releases.')}</p>
     )}
-    {manifest.js('label/index.js', {async: 'async'})}
+    {manifest.js('label/index', {async: 'async'})}
   </LabelLayout>
 );
 

root/place/PlaceIndex.js

@@ -46,7 +46,7 @@ const PlaceIndex = ({
       entity={place}
     />
     <Relationships source={place} />
-    {manifest.js('place/index.js', {async: 'async'})}
+    {manifest.js('place/index', {async: 'async'})}
   </PlaceLayout>
 );
 

root/place/PlaceMap.js

@@ -34,7 +34,7 @@ const PlaceMap = ({
       DBDefs.MAPBOX_ACCESS_TOKEN ? (
         <>
           <div id="largemap" />
-          {manifest.js('place/map.js', {'data-args': mapDataArgs})}
+          {manifest.js('place/map', {'data-args': mapDataArgs})}
         </>
       ) : (
         <p>

root/recording/RecordingMerge.js

@@ -73,7 +73,7 @@ const RecordingMerge = ({
         </EnterEdit>
       </form>
     </div>
-    {manifest.js('recording/merge.js', {async: 'async'})}
+    {manifest.js('recording/merge', {async: 'async'})}
   </Layout>
 );
 

root/relationship/linktype/RelationshipTypePairTree.js

@@ -174,7 +174,7 @@ const RelationshipTypePairTree = ({
         {type0: formattedType0, type1: formattedType1},
       )}
     >
-      {manifest.js('edit.js')}
+      {manifest.js('edit')}
       <div id="content">
         <RelationshipsHeader />
 

root/release_group/ReleaseGroupIndex.js

@@ -186,7 +186,7 @@ const ReleaseGroupIndex = ({
         </div>
       </>
     )}
-    {manifest.js('release-group/index.js', {async: 'async'})}
+    {manifest.js('release-group/index', {async: 'async'})}
   </ReleaseGroupLayout>
 );
 

root/series/SeriesIndex.js

@@ -153,7 +153,7 @@ const SeriesIndex = ({
       )}
 
       <Relationships source={series} />
-      {manifest.js('series/index.js', {async: 'async'})}
+      {manifest.js('series/index', {async: 'async'})}
     </SeriesLayout>
   );
 };

root/static/manifest.js

@@ -39,8 +39,10 @@ function js(
   manifest: string,
   extraAttrs?: {+'async'?: 'async', +'data-args'?: mixed} | null = null,
 ): React.Element<'script'> {
-  if (!jsExt.test(manifest)) {
-    manifest += '.js';
+  if (jsExt.test(manifest)) {
+    throw new Error(
+      'Do not include .js in the manifest path name',
+    );
   }
   return (
     <script

root/work/WorkIndex.js

@@ -60,7 +60,7 @@ const WorkIndex = ({
       pagedLinkTypeGroup={pagedLinkTypeGroup}
       pager={pager}
     />
-    {manifest.js('work/index.js', {async: 'async'})}
+    {manifest.js('work/index', {async: 'async'})}
   </WorkLayout>
 );