Skip to content

Commit 80719d5

Browse files
committed
Merge branch 'production'
* production: MBS-11468: ISE on "Edit cover art" edits MBS-11470: Ensure to_json_object(type) does run in Area::Edit
2 parents 4a2913b + c79bc66 commit 80719d5

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

lib/MusicBrainz/Server/Edit/Area/Edit.pm

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ sub build_display_data
116116
$data->{ended}{new} = boolean_to_json($data->{ended}{new});
117117
}
118118

119-
if (exists $self->data->{new}{type}) {
119+
if (exists $self->data->{new}{type_id}) {
120120
$data->{type}{old} = to_json_object($data->{type}{old});
121121
$data->{type}{new} = to_json_object($data->{type}{new});
122122
}

lib/MusicBrainz/Server/Edit/Release/EditCoverArt.pm

+4-3
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,16 @@ sub build_display_data {
131131

132132
my %data;
133133

134-
$data{release} = to_json_object(
134+
my $release = (
135135
$loaded->{Release}{ $self->data->{entity}{id} } ||
136136
Release->new( name => $self->data->{entity}{name} )
137137
);
138138

139+
$data{release} = to_json_object($release);
140+
139141
$data{artwork} = to_json_object(
140142
$loaded->{Artwork}{ $self->data->{id} } ||
141-
Artwork->new(release => $data{release},
143+
Artwork->new(release => $release,
142144
id => $self->data->{id},
143145
comment => $self->data->{new}{comment} // '',
144146
cover_art_types => [ map {
@@ -147,7 +149,6 @@ sub build_display_data {
147149
)
148150
);
149151

150-
151152
if ($self->data->{old}{types})
152153
{
153154
$data{types} = {

0 commit comments

Comments
 (0)