Remove EnvironmentPlugin

process.env.NODE_ENV is not referenced in any client scripts.

process.env.MUSICBRAINZ_RUNNING_TESTS is, but debounce.js is not used in
Node, so there's no reason to use process.env here.

Author: mwiencek

.eslintrc.yaml

@@ -24,6 +24,7 @@ globals:
   __webpack_public_path__: writable
   __DEV__: readonly
   GLOBAL_JS_NAMESPACE: readonly
+  MUSICBRAINZ_RUNNING_TESTS: readonly
   addColon: readonly
   addColonText: readonly
   hasOwnProp: readonly

root/static/scripts/common/utility/debounce.js

@@ -25,7 +25,10 @@ export function debounceComputed(value, delay) {
   if (!ko.isObservable(value)) {
     value = ko.computed(value);
   }
-  if (process.env.MUSICBRAINZ_RUNNING_TESTS) {
+  if (
+    typeof MUSICBRAINZ_RUNNING_TESTS !== 'undefined' &&
+    MUSICBRAINZ_RUNNING_TESTS
+  ) {
     return value;
   }
   return value.extend({

root/vars.js

@@ -18,6 +18,7 @@
 declare var __webpack_public_path__: string;
 declare var __DEV__: boolean;
 declare var GLOBAL_JS_NAMESPACE: '__MB__';
+declare var MUSICBRAINZ_RUNNING_TESTS: false;
 
 declare var addColon: (variable: Expand2ReactInput) => Expand2ReactOutput;
 declare var addColonText: (variable: StrOrNum) => string;

script/.check_eslint_rule_config.yaml

@@ -21,6 +21,7 @@ globals:
   __webpack_public_path__: writable
   __DEV__: readonly
   GLOBAL_JS_NAMESPACE: readonly
+  MUSICBRAINZ_RUNNING_TESTS: readonly
   addColon: readonly
   addColonText: readonly
   hasOwnProp: readonly

webpack/browserConfig.js

@@ -29,11 +29,6 @@ module.exports = {
     new webpack.IgnorePlugin({
       resourceRegExp: /\/DBDefs(?:-client-values)?$/,
     }),
-
-    new webpack.EnvironmentPlugin({
-      MUSICBRAINZ_RUNNING_TESTS: false,
-      NODE_ENV: process.env.NODE_ENV || 'development',
-    }),
   ],
 
   resolve: {

webpack/definePluginConfig.js

@@ -20,4 +20,6 @@ module.exports = {
    */
   __DEV__: JSON.stringify(WEBPACK_MODE === 'development'),
   GLOBAL_JS_NAMESPACE: JSON.stringify(GLOBAL_JS_NAMESPACE),
+  MUSICBRAINZ_RUNNING_TESTS:
+    JSON.stringify(!!process.env.MUSICBRAINZ_RUNNING_TESTS),
 };