MBS-11760: Add missing delete_unused_tag triggers

For some reason, we did not have delete_unused_tag triggers
for every taggable entity type. This was causing tags deleted
from the missing entity types to remain in the DB with 0 uses.

Author: reosarevok

admin/sql/CreateTriggers.sql

@@ -1036,34 +1036,50 @@ CREATE CONSTRAINT TRIGGER delete_unused_tag
 AFTER INSERT ON tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag();
 
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON area_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
 CREATE CONSTRAINT TRIGGER delete_unused_tag
 AFTER DELETE ON artist_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON event_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON instrument_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
 CREATE CONSTRAINT TRIGGER delete_unused_tag
 AFTER DELETE ON label_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
 CREATE CONSTRAINT TRIGGER delete_unused_tag
-AFTER DELETE ON release_group_tag DEFERRABLE INITIALLY DEFERRED
+AFTER DELETE ON place_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
 CREATE CONSTRAINT TRIGGER delete_unused_tag
-AFTER DELETE ON work_tag DEFERRABLE INITIALLY DEFERRED
+AFTER DELETE ON recording_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
 CREATE CONSTRAINT TRIGGER delete_unused_tag
-AFTER DELETE ON area_tag DEFERRABLE INITIALLY DEFERRED
+AFTER DELETE ON release_group_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
 CREATE CONSTRAINT TRIGGER delete_unused_tag
-AFTER DELETE ON instrument_tag DEFERRABLE INITIALLY DEFERRED
+AFTER DELETE ON release_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
 CREATE CONSTRAINT TRIGGER delete_unused_tag
 AFTER DELETE ON series_tag DEFERRABLE INITIALLY DEFERRED
 FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
 
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON work_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
 --------------------------------------------------------------------------------
 CREATE CONSTRAINT TRIGGER apply_artist_release_group_pending_updates
     AFTER INSERT OR UPDATE OR DELETE ON release DEFERRABLE INITIALLY DEFERRED

admin/sql/DropTriggers.sql

@@ -314,13 +314,17 @@ DROP TRIGGER url_gc_a_del_l_url_url ON l_url_url;
 DROP TRIGGER url_gc_a_upd_l_url_work ON l_url_work;
 DROP TRIGGER url_gc_a_del_l_url_work ON l_url_work;
 DROP TRIGGER delete_unused_tag ON tag;
+DROP TRIGGER delete_unused_tag ON area_tag;
 DROP TRIGGER delete_unused_tag ON artist_tag;
+DROP TRIGGER delete_unused_tag ON event_tag;
+DROP TRIGGER delete_unused_tag ON instrument_tag;
 DROP TRIGGER delete_unused_tag ON label_tag;
+DROP TRIGGER delete_unused_tag ON place_tag;
+DROP TRIGGER delete_unused_tag ON recording_tag;
 DROP TRIGGER delete_unused_tag ON release_group_tag;
-DROP TRIGGER delete_unused_tag ON work_tag;
-DROP TRIGGER delete_unused_tag ON area_tag;
-DROP TRIGGER delete_unused_tag ON instrument_tag;
+DROP TRIGGER delete_unused_tag ON release_tag;
 DROP TRIGGER delete_unused_tag ON series_tag;
+DROP TRIGGER delete_unused_tag ON work_tag;
 DROP TRIGGER apply_artist_release_group_pending_updates ON release;
 DROP TRIGGER apply_artist_release_pending_updates ON release;
 DROP TRIGGER apply_artist_release_pending_updates ON release_country;

admin/sql/updates/20210702-mbs-11760.sql

@@ -0,0 +1,21 @@
+\set ON_ERROR_STOP 1
+
+BEGIN;
+
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON event_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON place_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON recording_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
+CREATE CONSTRAINT TRIGGER delete_unused_tag
+AFTER DELETE ON release_tag DEFERRABLE INITIALLY DEFERRED
+FOR EACH ROW EXECUTE PROCEDURE trg_delete_unused_tag_ref();
+
+COMMIT;

upgrade.json

@@ -104,6 +104,7 @@
 
   "27": {
     "slave": ["20210526-a_upd_release_event.sql",
-              "20210606-mbs-11682.sql"]
+              "20210606-mbs-11682.sql"],
+    "standalone": ["20210702-mbs-11760.sql"]
   }
 }