Add eslint-plugin-fb-flow; fixed use-indexed-access-type

See the patch notes for 0.157.0 at
https://github.com/facebook/flow/releases/tag/v0.157.0
where this plugin was announced.

Author: mwiencek

.eslintrc.yaml

@@ -6,6 +6,7 @@ plugins:
   - import
   - react
   - flowtype
+  - fb-flow
   - react-hooks
 
 env:
@@ -333,6 +334,12 @@ rules:
   flowtype/union-intersection-spacing: [warn, always]
   flowtype/use-flow-type: warn
 
+  #########################
+  # eslint-plugin-fb-flow #
+  #########################
+
+  fb-flow/use-indexed-access-type: error
+
   #############################
   # eslint-plugin-react-hooks #
   #############################

package.json

@@ -32,6 +32,7 @@
     "copy-webpack-plugin": "4.6.0",
     "core-js": "3.6.5",
     "detect-node": "2.0.3",
+    "eslint-plugin-fb-flow": "^0.0.2",
     "file-loader": "3.0.1",
     "filesize": "2.0.4",
     "generic-diff": "1.0.1",

root/collection/CollectionIndex.js

@@ -33,7 +33,7 @@ import CollectionLayout from './CollectionLayout';
 type PropsForEntity<T: CoreEntityT> = {
   +$c: CatalystContextT,
   +collection: CollectionT,
-  +collectionEntityType: $ElementType<T, 'entityType'>,
+  +collectionEntityType: T['entityType'],
   +entities: $ReadOnlyArray<T>,
   +order: string,
   +pager: PagerT,

root/edit/details/AddAnnotation.js

@@ -14,7 +14,7 @@ import DescriptiveLink
 import formatEntityTypeName
   from '../../static/scripts/common/utility/formatEntityTypeName';
 
-type AnnotatedEntityTypeT = $ElementType<AnnotatedEntityT, 'entityType'>;
+type AnnotatedEntityTypeT = AnnotatedEntityT['entityType'];
 
 type AddAnnotationEditT = {
   ...EditT,

root/recording/RecordingIndex.js

@@ -42,7 +42,7 @@ const RecordingAppearancesTable = ({
 }: {
   $c: CatalystContextT,
   recording: RecordingWithArtistCreditT,
-  tracks: $ElementType<Props, 'tracks'>,
+  tracks: Props['tracks'],
 }) => (
   <table className="tbl">
     <thead>

root/static/scripts/common/components/Autocomplete2.js

@@ -121,7 +121,7 @@ function setScrollPosition(menuId: string) {
 type InitialStateT<T: EntityItemT> = {
   +activeUser?: ActiveEditorT,
   +canChangeType?: (string) => boolean,
-  +entityType: $ElementType<T, 'entityType'>,
+  +entityType: T['entityType'],
   +id: string,
   +inputValue?: string,
   +placeholder?: string,

root/static/scripts/common/components/Autocomplete2/types.js

@@ -7,14 +7,14 @@
  * later version: http://www.gnu.org/licenses/gpl-2.0.txt
  */
 
-export type SearchableTypeT = $ElementType<EntityItemT, 'entityType'>;
+export type SearchableTypeT = EntityItemT['entityType'];
 
 export type StateT<T: EntityItemT> = {
   +activeUser: ActiveEditorT | null,
   +canChangeType?: (string) => boolean,
   +containerClass?: string,
   +disabled?: boolean,
-  +entityType: $ElementType<T, 'entityType'>,
+  +entityType: T['entityType'],
   +error: number,
   +highlightedIndex: number,
   +id: string,

yarn.lock

@@ -3004,6 +3004,11 @@ eslint-module-utils@^2.6.0:
     debug "^2.6.9"
     pkg-dir "^2.0.0"
 
+eslint-plugin-fb-flow@^0.0.2:
+  version "0.0.2"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-fb-flow/-/eslint-plugin-fb-flow-0.0.2.tgz#54a5d1699872863b86a79f19f39c3085bb65a517"
+  integrity sha512-Wp5u0rGWLbufdv6rKUoa6A3/DWF1Tc19F762apVmBg2edVET4LjHIApsMl+LIzuRw767uTGF9BB9KuPtrakM0g==
+
 [email protected]:
   version "5.2.0"
   resolved "https://registry.yarnpkg.com/eslint-plugin-flowtype/-/eslint-plugin-flowtype-5.2.0.tgz#a4bef5dc18f9b2bdb41569a4ab05d73805a3d261"