Added code-coverage.yml using codecov (pytorch#1665)

* Create code-coverage.yml

* Update code-coverage.yml

* Update code-coverage.yml

* Update code-coverage.yml

* Update code-coverage.yml

* update test

* fixed python code coverage

* push

* push

* test

* push'

* Update code-coverage.yml

* changed naming

* Update modelarchiver_utils.py

* Update frontend_utils.py

* Update code-coverage.yml

* Update frontend_utils.py

* Update frontend_utils.py

* put coverage in GPU CI action

* codecov.yml

* Update ci_cpu.yml

* removed deprecated install file

* Update backend_utils.py

* Update backend_utils.py

Author: msaroufim

.github/workflows/ci_cpu.yml

@@ -40,5 +40,13 @@ jobs:
           python torchserve_sanity.py
       - name: mvn install
         run: cd serving-sdk/ && mvn clean install -q && cd ../
+        
+      # Any coverage.xml will be picked up by this step
+      # Just make sure each coverage.xml is in a different folder
+      - name: Upload codecov
+        run : |
+          curl -Os https://uploader.codecov.io/latest/linux/codecov
+          chmod +x codecov
+          ./codecov
 
 

.github/workflows/ci_gpu.yml

@@ -44,3 +44,11 @@ jobs:
       - name: mvn install
         run: cd serving-sdk/ && mvn clean install -q && cd ../
 
+      # Any coverage.xml will be picked up by this step
+      # Just make sure each coverage.xml is in a different folder
+      - name: Upload codecov
+        run : |
+          curl -Os https://uploader.codecov.io/latest/linux/codecov
+          chmod +x codecov
+          ./codecov
+

codecov.yml

@@ -0,0 +1,4 @@
+coverage:
+  range: 42..100
+  round: down
+  precision: 2

ts_scripts/backend_utils.py

@@ -6,21 +6,16 @@ def test_torchserve():
     # Lint Test
     print("## Started torchserve linting")
     ts_dir = os.path.join("ts", ".")
-    rc_file_path = os.path.join(".", "ts", "tests", "pylintrc")
-    py_lint_cmd = f"pylint -rn --rcfile={rc_file_path} {ts_dir}"
-    print(f"## In directory: {os.getcwd()} | Executing command: {py_lint_cmd}")
-    py_lint_exit_code = os.system(py_lint_cmd)
 
     # Execute python tests
     print("## Started torchserve pytests")
     test_dir = os.path.join("ts", "tests", "unit_tests")
     coverage_dir = os.path.join("ts")
-    results_dir_name = "result_units"
-    py_test_cmd = f"python -m pytest --cov-report html:{results_dir_name} --cov={coverage_dir} {test_dir}"
-    print(f"## In directory: {os.getcwd()} | Executing command: {py_test_cmd}")
-    py_test_exit_code = os.system(py_test_cmd)
+    report_output_dir = os.path.join(test_dir, "coverage.xml")
 
-    if py_lint_exit_code != 0:
-        print("## TorchServe Linting Failed !")
-    if py_test_exit_code != 0:
+    ts_test_cmd = f"python -m pytest --cov-report xml:{report_output_dir} --cov={coverage_dir} {test_dir}"
+    print(f"## In directory: {os.getcwd()} | Executing command: {ts_test_cmd}")
+    ts_test_error_code = os.system(ts_test_cmd)
+
+    if ts_test_error_code != 0:
         sys.exit("## TorchServe Pytests Failed !")

ts_scripts/install_utils

@@ -304,4 +304,4 @@ run_markdown_link_checker(){
   done
   set -e
   exit $STATUS
-}
+}

ts_scripts/modelarchiver_utils.py

@@ -1,40 +1,32 @@
 import os
 import sys
 
-
 REPO_ROOT = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..")
 sys.path.append(REPO_ROOT)
 
 
 def test_modelarchiver():
     os.chdir("model-archiver")
 
-    # Lint test
-    print("## Started model archiver linting")
-    ma_dir = os.path.join("model_archiver", ".")
-    rc_file_path = os.path.join(".", "model_archiver", "tests", "pylintrc")
-    py_lint_cmd = f"pylint -rn --rcfile={rc_file_path} {ma_dir}"
-    print(f"## In directory: {os.getcwd()} | Executing command: {py_lint_cmd}")
-    py_lint_exit_code = os.system(py_lint_cmd)
-
     # Execute python unit tests
     print("## Started model archiver pytests - unit tests")
     ut_dir = os.path.join("model_archiver", "tests", "unit_tests")
     coverage_dir = os.path.join(".")
-    results_dir_name = "result_units"
-    py_units_cmd = f"python -m pytest --cov-report html:{results_dir_name} --cov={coverage_dir} {ut_dir}"
+    report_output_dir = os.path.join(ut_dir, "coverage.xml")
+
+    py_units_cmd = f"python -m pytest --cov-report xml:{report_output_dir} --cov={coverage_dir} {ut_dir}"
     print(f"## In directory: {os.getcwd()} | Executing command: {py_units_cmd}")
     py_units_exit_code = os.system(py_units_cmd)
 
     # Execute integration tests
     print("## Started model archiver pytests - integration tests")
     it_dir = os.path.join("model_archiver", "tests", "integ_tests")
-    py_integ_cmd = f"python -m pytest {it_dir}" # ToDo - Report for Integration tests ?
+    report_output_dir = os.path.join(it_dir, "coverage.xml")
+
+    py_integ_cmd = f"python -m pytest --cov-report xml:{report_output_dir} --cov={coverage_dir} {it_dir}"
     print(f"## In directory: {os.getcwd()} | Executing command: {py_integ_cmd}")
     py_integ_exit_code = os.system(py_integ_cmd)
 
-    if py_lint_exit_code != 0:
-        print("## Model archiver Linting Failed !")
     if py_units_exit_code != 0:
         sys.exit("## Model archiver Unit Pytests Failed !")
     if py_integ_exit_code != 0:

ts_scripts/workflow_archiver_utils.py

@@ -1,40 +1,30 @@
 import os
 import sys
 
-
 REPO_ROOT = os.path.join(os.path.dirname(os.path.abspath(__file__)), "..")
 sys.path.append(REPO_ROOT)
 
 
 def test_workflow_archiver():
     os.chdir("workflow-archiver")
 
-    # Lint test
-    print("## Started model archiver linting")
-    workflow_archiver_dir = os.path.join("workflow_archiver", ".")
-    rc_file_path = os.path.join(".", "workflow_archiver", "tests", "pylintrc")
-    py_lint_cmd = f"pylint -rn --rcfile={rc_file_path} {workflow_archiver_dir}"
-    print(f"## In directory: {os.getcwd()} | Executing command: {py_lint_cmd}")
-    py_lint_exit_code = os.system(py_lint_cmd)
-
     # Execute python unit tests
     print("## Started workflow archiver pytests - unit tests")
     ut_dir = os.path.join("workflow_archiver", "tests", "unit_tests")
     coverage_dir = os.path.join(".")
-    results_dir_name = "result_units"
-    py_units_cmd = f"python -m pytest --cov-report html:{results_dir_name} --cov={coverage_dir} {ut_dir}"
+    report_output_dir = os.path.join(ut_dir, "coverage.xml")
+    py_units_cmd = f"python -m pytest --cov-report xml:{report_output_dir} --cov={coverage_dir} {ut_dir}"
     print(f"## In directory: {os.getcwd()} | Executing command: {py_units_cmd}")
     py_units_exit_code = os.system(py_units_cmd)
 
     # Execute integration tests
     print("## Started workflow archiver pytests - integration tests")
     it_dir = os.path.join("workflow_archiver", "tests", "integ_tests")
-    py_integ_cmd = f"python -m pytest {it_dir}" # ToDo - Report for Integration tests ?
+    report_output_dir = os.path.join(it_dir, "coverage.xml")
+    py_integ_cmd = f"python -m pytest --cov-report xml:{report_output_dir} --cov={coverage_dir} {it_dir}"
     print(f"## In directory: {os.getcwd()} | Executing command: {py_integ_cmd}")
     py_integ_exit_code = os.system(py_integ_cmd)
 
-    if py_lint_exit_code != 0:
-        print("## Workflow archiver Linting Failed !")
     if py_units_exit_code != 0:
         sys.exit("## Workflow archiver Unit Pytests Failed !")
     if py_integ_exit_code != 0: