deps: V8: cherry-pick c172ffc5bf54 #57437
Merged
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
Original commit message:
Compact retained maps array more often
When we add maps to the retained maps array, we compacted the array if
it's full. But, since we are now adding maps in a batch, it's unlikely
to meet the condition. Thus, update the condition to check whether new
size exceeds the capacity.
Bug: 398528460
Change-Id: I89caa47b69532c6397596edfe5caf7c7d24768cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6330019
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#99163}
Refs: v8/v8@c172ffc
tunamagur0
force-pushed
the
retained-map-increase
branch
from
2dd51aa to
282a23e
Compare
lpinca
approved these changes
Mar 13, 2025
github-actions
bot
removed
the
request-ci
targos
approved these changes
Mar 14, 2025
richardlau
approved these changes
Mar 14, 2025
richardlau
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57437 ✔ Done loading data for nodejs/node/pull/57437 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick c172ffc5bf54 (#57437) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tunamagur0:retained-map-increase -> nodejs:main Labels build, v8 engine, needs-ci, lts-watch-v22.x Commits 1 - deps: V8: cherry-pick c172ffc5bf54 Committers 1 - tunamagur0 <47546832+tunamagur0@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/57437 Fixes: https://github.com/nodejs/node/issues/57412 Refs: https://github.com/v8/v8/commit/c172ffc5bf54e704558103973e1d5cb7aec491cb Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57437 Fixes: https://github.com/nodejs/node/issues/57412 Refs: https://github.com/v8/v8/commit/c172ffc5bf54e704558103973e1d5cb7aec491cb Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 13 Mar 2025 09:42:27 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57437#pullrequestreview-2683348686 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/57437#pullrequestreview-2684581458 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57437#pullrequestreview-2685912551 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-03-15T00:39:12Z: https://ci.nodejs.org/job/node-test-pull-request/65762/ - Querying data for job/node-test-pull-request/65762/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13871726497 |
richardlau
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57437 ✔ Done loading data for nodejs/node/pull/57437 ----------------------------------- PR info ------------------------------------ Title deps: V8: cherry-pick c172ffc5bf54 (#57437) Author tunamagur0 <tsunamaguro3@gmail.com> (@tunamagur0, first-time contributor) Branch tunamagur0:retained-map-increase -> nodejs:main Labels build, v8 engine, needs-ci, lts-watch-v22.x Commits 1 - deps: V8: cherry-pick c172ffc5bf54 Committers 1 - tunamagur0 <47546832+tunamagur0@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/57437 Fixes: https://github.com/nodejs/node/issues/57412 Refs: https://github.com/v8/v8/commit/c172ffc5bf54e704558103973e1d5cb7aec491cb Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57437 Fixes: https://github.com/nodejs/node/issues/57412 Refs: https://github.com/v8/v8/commit/c172ffc5bf54e704558103973e1d5cb7aec491cb Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 13 Mar 2025 09:42:27 GMT ✔ Approvals: 3 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57437#pullrequestreview-2683348686 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/57437#pullrequestreview-2684581458 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57437#pullrequestreview-2685912551 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-03-15T09:50:32Z: https://ci.nodejs.org/job/node-test-pull-request/65762/ - Querying data for job/node-test-pull-request/65762/ ✔ Last Jenkins CI successful ⚠ PR author is a new contributor: @tunamagur0(tsunamaguro3@gmail.com) ⚠ - commit 282a23e4c16e is authored by choongwoo.han@microsoft.com -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13873396665 |
|
I'm not very familiar with the system, but could the failure be due to some of the checks being canceled? |
aduh95
pushed a commit
that referenced
this pull request
Mar 16, 2025
Original commit message:
Compact retained maps array more often
When we add maps to the retained maps array, we compacted the array if
it's full. But, since we are now adding maps in a batch, it's unlikely
to meet the condition. Thus, update the condition to check whether new
size exceeds the capacity.
Bug: 398528460
Change-Id: I89caa47b69532c6397596edfe5caf7c7d24768cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6330019
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#99163}
Refs: v8/v8@c172ffc
PR-URL: #57437
Fixes: #57412
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Co-Authored-By: tunamagur0
<47546832+tunamagur0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #57412
This upstream V8 commit fixes the issue where the size of RetainedMaps continuously increases, leading to higher memory usage.
This issue has been occurring since AddRetainedMap was changed to AddRetainedMaps in the commit d8c97e48573ef9679751be0c7a308e08d0101c47.
As a result, the Main branch, v23.x.x, and v22.x.x should need this.
Original commit message:
Refs: v8/v8@c172ffc