watch: check parent and child path properly #57425
Conversation
jazelly
force-pushed
the
fix-57422
branch
3 times, most recently
from
bb7f643 to
7a81702
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57425 +/- ##
==========================================
+ Coverage 90.21% 90.23% +0.01%
==========================================
Files 629 629
Lines 185126 184963 -163
Branches 36225 36223 -2
==========================================
- Hits 167016 166900 -116
+ Misses 11055 11019 -36
+ Partials 7055 7044 -11
🚀 New features to boost your workflow:
|
jazelly
force-pushed
the
fix-57422
branch
2 times, most recently
from
a9aa5b0 to
711c301
Compare
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
|
Hi folks @nodejs/build - could you take a look at this failure |
| // The file is reloaded due to file watching | ||
| if (completeCount === 2) { | ||
| child.kill(); | ||
| await once(child, 'exit'); |
There was a problem hiding this comment.
nit: I missed that earlier, but we don't really need to wait for the 'exit' event here, since we already await for child.stdout to close in the for await. We can also keep it, it's fine
| await once(child, 'exit'); |
| if (line.startsWith('Completed running')) { | ||
| completeCount++; | ||
| } |
There was a problem hiding this comment.
btw should we skip running appendFileSync and child.kill if there are unrelated lines??
| if (line.startsWith('Completed running')) { | |
| completeCount++; | |
| } | |
| if (!line.startsWith('Completed running')) { | |
| continue; | |
| } | |
| completeCount++; |
There was a problem hiding this comment.
Yeah I think that would be better to avoid unnecessary appends
co-authored-by: Jake Yuesong Li <[email protected]>
Fixes: #57422