-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Memory leak due to increasing RetainedMaps size in V8 (Fixed upstream) #57412
Comments
That's amazing! Could you please send us your patch? This https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-V8.md may be handy |
@juanarbol |
aduh95
pushed a commit
that referenced
this issue
Mar 16, 2025
Original commit message: Compact retained maps array more often When we add maps to the retained maps array, we compacted the array if it's full. But, since we are now adding maps in a batch, it's unlikely to meet the condition. Thus, update the condition to check whether new size exceeds the capacity. Bug: 398528460 Change-Id: I89caa47b69532c6397596edfe5caf7c7d24768cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6330019 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Choongwoo Han <choongwoo.han@microsoft.com> Cr-Commit-Position: refs/heads/main@{#99163} Refs: v8/v8@c172ffc PR-URL: #57437 Fixes: #57412 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Co-Authored-By: tunamagur0 <47546832+tunamagur0@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v22.14.0
Platform
Subsystem
v8
What steps will reproduce the bug?
--expose-gc
.(system) > system / NativeContext > retained_maps :: system / WeakArrayList
Note:
The increase is gradual, so it may take several hours to see a significant difference.
However, even within a shorter period, a steady increase should still be observable.
How often does it reproduce? Is there a required condition?
It reproduces consistently.
What is the expected behavior? Why is that the expected behavior?
RetainedMaps size should remain stable over time.
What do you see instead?
Eventually, this could result in performance degradation or excessive memory usage.
Below are screenshots showing the memory usage:
v22.14.0
v22.14.0 (with the patch applied)
Additional information
e5a29df7b41416de67730d2968c61745b54be66c
V8 Issue 398528460
The text was updated successfully, but these errors were encountered: