Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose createErrDiff for diffing objects #51740

Open
JMTK opened this issue Feb 13, 2024 · 3 comments · May be fixed by #57462
Open

Expose createErrDiff for diffing objects #51740

JMTK opened this issue Feb 13, 2024 · 3 comments · May be fixed by #57462
Labels
feature request Issues that request new features to be added to Node.js.

Comments

@JMTK
Copy link

JMTK commented Feb 13, 2024

What is the problem this feature will solve?

I like the general format of the deepStrictEqual diff comparisons, but it would be nice to get this functionality "natively" to print a diff instead of forcing it to error to see a diff.

What is the feature you are proposing to solve the problem?

Expose createErrDiff from assert

node/lib/internal/assert/assertion_error.js

Line 79 in 544cfc5

function createErrDiff(actual, expected, operator) {

What alternatives have you considered?

Userland diff tool, but if the code is already there it would be nice to expose it
@JMTK JMTK added the feature request Issues that request new features to be added to Node.js. label Feb 13, 2024
@BridgeAR
Copy link
Member

The current implementation is not ideal. I would not expose that for now. It is just a best effort implementation and not e.g., Myers .

@avivkeller
Copy link
Member

Just a little update here: #54862 will switch the alg to Myers

@github-actions GitHub Actions
Copy link
Contributor

There has been no activity on this feature request for 5 months. To help maintain relevant open issues, please add the never-stale Mark issue so that it is never considered stale label or close this issue if it should be closed. If not, the issue will be automatically closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.

@github-actions github-actions bot added the stale label Mar 14, 2025
puskin94 added a commit to puskin94/node that referenced this issue Mar 14, 2025
@puskin94
util: expose diff function used by the assertion errors.
2945c4e 
fix: nodejs#51740
puskin94 added a commit to puskin94/node that referenced this issue Mar 14, 2025
@puskin94
util: expose diff function used by the assertion errors.
f052eea 
fix: nodejs#51740
puskin94 added a commit to puskin94/node that referenced this issue Mar 14, 2025
@puskin94
util: expose diff function used by the assertion errors.
80237ce 
fix: nodejs#51740
puskin94 added a commit to puskin94/node that referenced this issue Mar 14, 2025
@puskin94
util: expose diff function used by the assertion errors.
1905f00 
fix: nodejs#51740
@puskin94 puskin94 linked a pull request Mar 14, 2025 that will close this issue
Open
puskin94 added a commit to puskin94/node that referenced this issue Mar 14, 2025
@puskin94
util: expose diff function used by the assertion errors
480d3c7 
fix: nodejs#51740
puskin94 added a commit to puskin94/node that referenced this issue Mar 14, 2025
@puskin94
util: expose diff function used by the assertion errors
518712d 
fix: nodejs#51740
@pmarchini pmarchini removed the stale label Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js.
Projects
Node.js feature requests
Status: Awaiting Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util: expose diff function used by the assertion errors puskin94/node
4 participants
@JMTK @BridgeAR @avivkeller @pmarchini