fix: improve error message

JeyJeyGao · JeyJeyGao · commit c14721f47104 · 2025-03-04T06:41:29.000Z
Signed-off-by: Junjie Gao &lt;junjiegao@microsoft.com&gt;
diff --git a/verifier/trustpolicy/trustpolicy.go b/verifier/trustpolicy/trustpolicy.go
@@ -337,7 +337,7 @@ func validateTrustedIdentities(policyName string, tis []string) error {
 		if identity != trustpolicy.Wildcard {
 			identityPrefix, identityValue, found := strings.Cut(identity, ":")
 			if !found {
-				return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator", policyName, identity)
+				return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator. The required format is <trustedIdentityType>:<trustedIdentityValues>", policyName, identity)
 			}
 
 			// notation natively supports x509.subject identities only
diff --git a/verifier/verifier.go b/verifier/verifier.go
@@ -936,7 +936,7 @@ func verifyX509TrustedIdentities(policyName string, trustedIdentities []string,
 	for _, identity := range trustedIdentities {
 		identityPrefix, identityValue, found := strings.Cut(identity, ":")
 		if !found {
-			return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator", policyName, identity)
+			return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator. The required format is <trustedIdentityType>:<trustedIdentityValues>", policyName, identity)
 		}
 
 		// notation natively supports x509.subject identities only

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,7 @@ func validateTrustedIdentities(policyName string, tis []string) error {`
`337`	`337`	`if identity != trustpolicy.Wildcard {`
`338`	`338`	`identityPrefix, identityValue, found := strings.Cut(identity, ":")`
`339`	`339`	`if !found {`
`340`		`- return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator", policyName, identity)`
	`340`	`+ return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator. The required format is <trustedIdentityType>:<trustedIdentityValues>", policyName, identity)`
`341`	`341`	`}`
`342`	`342`
`343`	`343`	`// notation natively supports x509.subject identities only`
Original file line number	Diff line number	Diff line change
`@@ -936,7 +936,7 @@ func verifyX509TrustedIdentities(policyName string, trustedIdentities []string,`
`936`	`936`	`for _, identity := range trustedIdentities {`
`937`	`937`	`identityPrefix, identityValue, found := strings.Cut(identity, ":")`
`938`	`938`	`if !found {`
`939`		`- return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator", policyName, identity)`
	`939`	`+ return fmt.Errorf("trust policy statement %q has trusted identity %q missing separator. The required format is <trustedIdentityType>:<trustedIdentityValues>", policyName, identity)`
`940`	`940`	`}`
`941`	`941`
`942`	`942`	`// notation natively supports x509.subject identities only`