Skip to content

Commit dec4a35

Browse files
committed
fix: resolve comment
Signed-off-by: Junjie Gao <[email protected]>
1 parent fc0a165 commit dec4a35

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

notation.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -206,15 +206,15 @@ func SignOCI(ctx context.Context, signer Signer, repo registry.Repository, signO
206206
_, sigManifestDesc, err = repo.PushSignature(ctx, signOpts.SignatureMediaType, sig, artifactManifestDesc, annotations)
207207
if err != nil {
208208
var referrerError *remote.ReferrersError
209-
if !errors.As(err, &referrerError) || !referrerError.IsReferrersIndexDelete() {
210-
logger.Error("Failed to push the signature")
211-
return ocispec.Descriptor{}, ocispec.Descriptor{}, ErrorPushSignatureFailed{Msg: err.Error()}
209+
if errors.As(err, &referrerError) && referrerError.IsReferrersIndexDelete() {
210+
// log warning if referrers index removal failed but signature
211+
// pushed succeeded
212+
logger.Warn("Removal of outdated referrers index from remote registry failed. Garbage collection may be required.")
213+
return artifactManifestDesc, sigManifestDesc, nil
212214
}
213215

214-
// log warning if referrers index removal failed but signature pushed
215-
// succeeded
216-
logger.Warn("Removal of outdated referrers index from remote registry failed. Garbage collection may be required.")
217-
return artifactManifestDesc, sigManifestDesc, nil
216+
logger.Error("Failed to push the signature")
217+
return ocispec.Descriptor{}, ocispec.Descriptor{}, ErrorPushSignatureFailed{Msg: err.Error()}
218218
}
219219
return artifactManifestDesc, sigManifestDesc, nil
220220
}

0 commit comments

Comments
 (0)