|
| 1 | +# Kvdb Destination |
| 2 | + |
| 3 | +This is the repository for the [Kvdb](https://kvdb.io) destination connector, written in Python. It is intended to be an example for how to write a Python destination. KvDB is a very simple key value store, which makes it great for the purposes of illustrating how to write a Python destination connector. |
| 4 | + |
| 5 | +## Local development |
| 6 | + |
| 7 | +### Prerequisites |
| 8 | +**To iterate on this connector, make sure to complete this prerequisites section.** |
| 9 | + |
| 10 | +#### Minimum Python version required `= 3.7.0` |
| 11 | + |
| 12 | +#### Build & Activate Virtual Environment and install dependencies |
| 13 | +From this connector directory, create a virtual environment: |
| 14 | +``` |
| 15 | +python -m venv .venv |
| 16 | +``` |
| 17 | + |
| 18 | +This will generate a virtualenv for this module in `.venv/`. Make sure this venv is active in your |
| 19 | +development environment of choice. To activate it from the terminal, run: |
| 20 | +``` |
| 21 | +source .venv/bin/activate |
| 22 | +pip install -r requirements.txt |
| 23 | +``` |
| 24 | +If you are in an IDE, follow your IDE's instructions to activate the virtualenv. |
| 25 | + |
| 26 | +Note that while we are installing dependencies from `requirements.txt`, you should only edit `setup.py` for your dependencies. `requirements.txt` is |
| 27 | +used for editable installs (`pip install -e`) to pull in Python dependencies from the monorepo and will call `setup.py`. |
| 28 | +If this is mumbo jumbo to you, don't worry about it, just put your deps in `setup.py` but install using `pip install -r requirements.txt` and everything |
| 29 | +should work as you expect. |
| 30 | + |
| 31 | +#### Building via Gradle |
| 32 | +From the Airbyte repository root, run: |
| 33 | +``` |
| 34 | +./gradlew :airbyte-integrations:connectors:destination-kvdb:build |
| 35 | +``` |
| 36 | + |
| 37 | +#### Create credentials |
| 38 | +**If you are a community contributor**, generate the necessary credentials from [Kvdb](https://kvdb.io/docs/api/), and then create a file `secrets/config.json` conforming to the `destination_kvdb/spec.json` file. |
| 39 | +Note that the `secrets` directory is gitignored by default, so there is no danger of accidentally checking in sensitive information. |
| 40 | +See `integration_tests/sample_config.json` for a sample config file. |
| 41 | + |
| 42 | +**If you are an Airbyte core member**, copy the credentials in Lastpass under the secret name `destination kvdb test creds` |
| 43 | +and place them into `secrets/config.json`. |
| 44 | + |
| 45 | +### Locally running the connector |
| 46 | +``` |
| 47 | +python main.py spec |
| 48 | +python main.py check --config secrets/config.json |
| 49 | +python main.py discover --config secrets/config.json |
| 50 | +python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json |
| 51 | +``` |
| 52 | + |
| 53 | +### Locally running the connector docker image |
| 54 | + |
| 55 | + |
| 56 | + |
| 57 | +#### Build |
| 58 | +**Via [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md) (recommended):** |
| 59 | +```bash |
| 60 | +airbyte-ci connectors --name=destination-kvdb build |
| 61 | +``` |
| 62 | + |
| 63 | +An image will be built with the tag `airbyte/destination-kvdb:dev`. |
| 64 | + |
| 65 | +**Via `docker build`:** |
| 66 | +```bash |
| 67 | +docker build -t airbyte/destination-kvdb:dev . |
| 68 | +``` |
| 69 | +#### Run |
| 70 | +Then run any of the connector commands as follows: |
| 71 | +``` |
| 72 | +docker run --rm airbyte/destination-kvdb:dev spec |
| 73 | +docker run --rm -v $(pwd)/secrets:/secrets airbyte/destination-kvdb:dev check --config /secrets/config.json |
| 74 | +# messages.jsonl is a file containing line-separated JSON representing AirbyteMessages |
| 75 | +cat messages.jsonl | docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/destination-kvdb:dev write --config /secrets/config.json --catalog /integration_tests/configured_catalog.json |
| 76 | +``` |
| 77 | +## Testing |
| 78 | + Make sure to familiarize yourself with [pytest test discovery](https://docs.pytest.org/en/latest/goodpractices.html#test-discovery) to know how your test files and methods should be named. |
| 79 | +First install test dependencies into your virtual environment: |
| 80 | +``` |
| 81 | +pip install .[tests] |
| 82 | +``` |
| 83 | +### Unit Tests |
| 84 | +To run unit tests locally, from the connector directory run: |
| 85 | +``` |
| 86 | +python -m pytest unit_tests |
| 87 | +``` |
| 88 | + |
| 89 | +### Integration Tests |
| 90 | +There are two types of integration tests: Acceptance Tests (Airbyte's test suite for all destination connectors) and custom integration tests (which are specific to this connector). |
| 91 | +#### Custom Integration tests |
| 92 | +Place custom tests inside `integration_tests/` folder, then, from the connector root, run |
| 93 | +``` |
| 94 | +python -m pytest integration_tests |
| 95 | +``` |
| 96 | +#### Acceptance Tests |
| 97 | +You can run our full test suite locally using [`airbyte-ci`](https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/README.md): |
| 98 | +```bash |
| 99 | +airbyte-ci connectors --name=destination-kvdb test |
| 100 | +``` |
| 101 | + |
| 102 | + |
| 103 | +## Dependency Management |
| 104 | +All of your dependencies should go in `setup.py`, NOT `requirements.txt`. The requirements file is only used to connect internal Airbyte dependencies in the monorepo for local development. |
| 105 | +We split dependencies between two groups, dependencies that are: |
| 106 | +* required for your connector to work need to go to `MAIN_REQUIREMENTS` list. |
| 107 | +* required for the testing need to go to `TEST_REQUIREMENTS` list |
| 108 | + |
| 109 | +### Publishing a new version of the connector |
| 110 | +You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what? |
| 111 | +1. Make sure your changes are passing our test suite: `airbyte-ci connectors --name=destination-kvdb test` |
| 112 | +2. Bump the connector version in `metadata.yaml`: increment the `dockerImageTag` value. Please follow [semantic versioning for connectors](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#semantic-versioning-for-connectors). |
| 113 | +3. Make sure the `metadata.yaml` content is up to date. |
| 114 | +4. Make the connector documentation and its changelog is up to date (`docs/integrations/destinations/kvdb.md`). |
| 115 | +5. Create a Pull Request: use [our PR naming conventions](https://docs.airbyte.com/contributing-to-airbyte/resources/pull-requests-handbook/#pull-request-title-convention). |
| 116 | +6. Pat yourself on the back for being an awesome contributor. |
| 117 | +7. Someone from Airbyte will take a look at your PR and iterate with you to merge it into master. |
| 118 | + |
0 commit comments