-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTel .NET AutoInstrumentation - MySql.Data license dependency verification #2558
Comments
hi @Kielek! I can't find an answer about test dependencies in https://github.com/cncf/foundation. We have examples similar to this in Java instrumentation as well. |
oh sorry @danielgblanco I missed that you self-assigned this |
Yeah, we triaged this yesterday and I said I will open a Service Desk ticket for this. Will do now :) |
This is being looked at, to see if a license exception request is needed in this case. |
In the Java repositories we currently only run license scanning against published artifacts and their dependencies. Running license scanning against the build and test infrastructure doesn't make sense to me (but IANAL), e.g. the JDK itself is GNU General Public License, version 2, with the Classpath Exception. |
I will ping CNCF on this to see what the status is. |
I found this, which is almost on point https://github.com/cncf/foundation/blob/main/recommendations-for-attribution.md#scope-and-nature-of-dependencies
Update: I posted this to the cncf service desk ticket to see if it helps move things along at all... |
I've pinged the Service Desk ticket again. Still awaiting response. |
OpenTelemetry .NET Automatic Instrumentation provides instrumentation functionality to MySql.Data nuget package.
The production code does not contain any reference to MySql.Data nor /MySql.Data.OpenTelemetry. It is listening only on events/activities created by MySql.Data. It is handled by this substription.
MySql.Data library is referenced only in the testing applications.
Nuget packages are marked as
License GPL-2.0-only license licenseWITH license licenseUniversal-FOSS-exception-1.0 license
.We have a request to validate if it is fine to keep such dependency in our code, what are the implications of this?
The text was updated successfully, but these errors were encountered: