Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_go_string_from_user_ptr to add null byte at the end of a string #1936

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

RonFed
Copy link
Contributor

@RonFed RonFed commented Mar 5, 2025

Resolve #1928

@RonFed RonFed added the bug Something isn't working label Mar 5, 2025
@RonFed RonFed requested a review from a team as a code owner March 5, 2025 08:55
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch!

@MrAlias
Copy link
Contributor

MrAlias commented Mar 5, 2025

Can you add a changelog describing the fix?

@MrAlias
Copy link
Contributor

MrAlias commented Mar 5, 2025

It looks like this fails the verifier in the CI.

@skandragon
Copy link

LGTM! Nice catch!

You're welcome :)

We knew we did not have any kafkaesque topics like we were seeing, and from my C days, I pretty much knew what the problem was, just not where.

@RonFed
Copy link
Contributor Author

RonFed commented Mar 7, 2025

It looks like this fails the verifier in the CI.

The verifier seems to not like this in 5.4, tried a few options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka topic names are wrong, likely memory re-use issue
4 participants