Skip to content

Commit bfaabbf

Browse files
adriangbowais
andauthored
Make Falcon instrumentation compatible with Falcon >=3 (#607)
* Make Falcon instrumentation compatible with Falcon >=3 Replace falcon.api.Request -> falcon.Request which exists on both Falcon 2 & 3 * Update package.py * Update CHANGELOG.md * update tox.ini * revert changes to tox.ini to test failures * Update package.py Co-authored-by: Owais Lone <[email protected]>
1 parent 9c4eb69 commit bfaabbf

File tree

2 files changed

+3
-1
lines changed
  • instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon

2 files changed

+3
-1
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3030
([#595](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/595))
3131

3232
### Changed
33+
- `opentelemetry-instrumentation-falcon` added support for Falcon 3.
34+
([#607](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/607))
3335
- `opentelemetry-instrumentation-tornado` properly instrument work done in tornado on_finish method.
3436
([#499](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/499))
3537
- `opentelemetry-instrumentation` Fixed cases where trying to use an instrumentation package without the

instrumentation/opentelemetry-instrumentation-falcon/src/opentelemetry/instrumentation/falcon/__init__.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ def response_hook(span, req, resp):
126126

127127
_excluded_urls = get_excluded_urls("FALCON")
128128
_traced_request_attrs = get_traced_request_attrs("FALCON")
129-
_response_propagation_setter = FuncSetter(falcon.api.Response.append_header)
129+
_response_propagation_setter = FuncSetter(falcon.Response.append_header)
130130

131131

132132
class FalconInstrumentor(BaseInstrumentor):

0 commit comments

Comments
 (0)