Skip to content

Commit 81b351f

Browse files
committed
review comments
1 parent 50b3598 commit 81b351f

File tree

1 file changed

+18
-21
lines changed

1 file changed

+18
-21
lines changed

content/en/docs/kubernetes/operator/automatic.md

+18-21
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ For more details, see [.NET Auto Instrumentation docs](/docs/zero-code/net/).
183183
### Deno
184184
185185
The following command creates a basic Instrumentation resource that is
186-
configured for instrumenting Deno services.
186+
configured for instrumenting [Deno](https://deno.com) services.
187187
188188
```bash
189189
kubectl apply -f - <<EOF
@@ -220,26 +220,29 @@ the `otlpreceiver` of the Collector created in the previous step.
220220

221221
{{% alert title="Note" color="info" %}}
222222

223-
Deno's OpenTelemetry integration is not yet stable. As a result all workloads
224-
that want to be instrumented with Deno must have the `--unstable-otel` flag set
225-
when starting the Deno process.
223+
[Deno's OpenTelemetry integration][deno-otel-docs] is not yet stable. As a
224+
result all workloads that want to be instrumented with Deno must have the
225+
`--unstable-otel` flag set when starting the Deno process.
226226

227227
{{% /alert %}}
228228

229-
#### Configuring console.log capturing in Deno
229+
#### Configuration options
230230

231-
By default, the Deno OpenTelemetry integration captures `console.log` output as
232-
logs, while still printing the logs to stdout / stderr. There are two other
233-
behaviours that can be configured:
231+
By default, the Deno OpenTelemetry integration exports `console.log()` output as
232+
[logs](/docs/concepts/signals/logs/), while still printing the logs to stdout /
233+
stderr. You can configure these alternative behaviors:
234234

235-
- `OTEL_DENO_CONSOLE=replace`: capture `console.log` output as logs and do not
235+
- `OTEL_DENO_CONSOLE=replace`: only export `console.log()` output as logs; do
236+
not print to stdout / stderr.
237+
- `OTEL_DENO_CONSOLE=ignore`: do not export `console.log()` output as logs; do
236238
print to stdout / stderr.
237-
- `OTEL_DENO_CONSOLE=ignore`: do not capture `console.log` output as logs.
238239

239240
#### Learn more {#deno-learn-more}
240241

241-
For more details, see
242-
[Deno's documentation on the OpenTelemetry integration](https://docs.deno.com/runtime/fundamentals/open_telemetry/).
242+
For more details, see Deno's [OpenTelemetry integration][deno-otel-docs]
243+
documentation.
244+
245+
[deno-otel-docs]: https://docs.deno.com/runtime/fundamentals/open_telemetry/
243246

244247
### Java
245248

@@ -746,21 +749,15 @@ Here are a few things to check for:
746749
- **Is the auto-instrumentation for the right language?** For example, when
747750
instrumenting a Python application, make sure that the annotation doesn't
748751
incorrectly say `instrumentation.opentelemetry.io/inject-java: "true"`
749-
instead.
752+
instead. Note that Deno uses the uses the
753+
`instrumentation.opentelemetry.io/inject-sdk: "true"` annotation, rather than
754+
an annotation containing the string `deno`.
750755
- **Is the auto-instrumentation annotation in the correct location?** When
751756
defining a `Deployment`, annotations can be added in one of two locations:
752757
`spec.metadata.annotations`, and `spec.template.metadata.annotations`. The
753758
auto-instrumentation annotation needs to be added to
754759
`spec.template.metadata.annotations`, otherwise it won’t work.
755760

756-
{{% alert title="Note" color="info" %}}
757-
758-
Note that unlike other auto-instrumentation, the Deno auto-instrumentation uses
759-
the `instrumentation.opentelemetry.io/inject-sdk: "true"` annotation, not an
760-
annotation that contains the string `deno`.
761-
762-
{{% /alert %}}
763-
764761
### Was the auto-instrumentation endpoint configured correctly?
765762

766763
The `spec.exporter.endpoint` attribute of the `Instrumentation` resource defines

0 commit comments

Comments
 (0)