✅ [outreachy] Pagination/daphne

[Naggayi-Daphne-Pearl]

No description provided.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Naggayi-Daphne-Pearl / name: Naggayi Daphne Pearl (1fd9848, 4a19f61, 38422ed, 671b026, 20c2b26, c3c545f, f6432ca, a2a08f4, 00664c9, 950243b, 57f177c, 693db32, 775e5f6, 54f9f4f, cb63d84)

[svrnm]

Thank you, this is a really good start. A Few comments inlined, 3 more here:

• Please review the CLA and if possible sign it, if you have any questions, ask via slack so we can discuss them with everyone else
• Make sure that you do not introduce unrelated format changes, this makes reviewing your work much harder
• (optional) add a feature that the current page and the number of items per page are added to the URL and read from the url (e.g. ?page=5&itemsPerPage=50)

[svrnm]

@Naggayi-Daphne-Pearl look good overall! Can you run npm run fix:all locally and submit the changes, this should also make sure that the CI issues get resolved.

[svrnm]

Thank you @Naggayi-Daphne-Pearl! This looks really good, I consider this as done!

[svrnm]

@Naggayi-Daphne-Pearl thanks for working on this during the outreachy application phase! As discussed the issue with pagination is that we can not solve it on the server side, so while it is visually reducing the number of items seen still the whole amount of items is loaded from the server. We might want to revisit this and think about a server side solution, but for now I will close this PR.