Skip to content

Commit 8b1de50

Browse files
addressing nits
1 parent 7367c91 commit 8b1de50

File tree

9 files changed

+9
-21
lines changed

9 files changed

+9
-21
lines changed

cumulus/polkadot-parachain/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ hex-literal = { workspace = true, default-features = true }
2222
log = { workspace = true, default-features = true }
2323
serde = { features = ["derive"], workspace = true, default-features = true }
2424
serde_json = { workspace = true, default-features = true }
25+
clap = { features = ["derive"], workspace = true }
2526

2627
# Local
2728
asset-hub-rococo-runtime = { workspace = true, default-features = true }
@@ -51,7 +52,6 @@ sp-keyring = { workspace = true, default-features = true }
5152
xcm = { workspace = true, default-features = true }
5253

5354
# Cumulus
54-
clap = { features = ["derive"], workspace = true }
5555
cumulus-primitives-core = { workspace = true, default-features = true }
5656

5757
[build-dependencies]

cumulus/polkadot-parachain/src/main.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
// Copyright (C) Parity Technologies (UK) Ltd.
22
// This file is part of Cumulus.
33
// SPDX-License-Identifier: Apache-2.0
4-
//
4+
55
// Licensed under the Apache License, Version 2.0 (the "License");
66
// you may not use this file except in compliance with the License.
77
// You may obtain a copy of the License at
88
//
9-
// http://www.apache.org/licenses/LICENSE-2.0
9+
// http://www.apache.org/licenses/LICENSE-2.0
1010
//
1111
// Unless required by applicable law or agreed to in writing, software
1212
// distributed under the License is distributed on an "AS IS" BASIS,
@@ -29,7 +29,6 @@ use polkadot_omni_node_lib::{
2929
};
3030
use sc_cli::ExportChainSpecCmd;
3131

32-
/// Custom CLI configuration for metadata.
3332
struct CliConfig;
3433

3534
impl CliConfigT for CliConfig {

cumulus/test/service/src/cli.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ impl Display for AuthoringPolicy {
8282
#[derive(Debug, clap::Subcommand)]
8383
pub enum Subcommand {
8484
/// Build a chain specification.
85-
/// #[deprecated( note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead")]
85+
/// DEPRECATED: `build-spec` command will be removed after 1/04/2026. Use `export-chain-spec` command instead.
8686
#[deprecated(
8787
note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead"
8888
)]

polkadot/cli/src/cli.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ use std::path::PathBuf;
2525
#[derive(Debug, Parser)]
2626
pub enum Subcommand {
2727
/// Build a chain specification.
28-
/// #[deprecated( note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead")]
28+
/// DEPRECATED: `build-spec` command will be removed after 1/04/2026. Use `export-chain-spec` command instead.
2929
#[deprecated(
3030
note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead"
3131
)]

substrate/bin/node/cli/src/cli.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ pub enum Subcommand {
7878
Sign(sc_cli::SignCmd),
7979

8080
/// Build a chain specification.
81-
/// #[deprecated( note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead")]
81+
/// DEPRECATED: `build-spec` command will be removed after 1/04/2026. Use `export-chain-spec` command instead.
8282
#[deprecated(
8383
note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead"
8484
)]

substrate/client/cli/src/commands/export_chain_spec_cmd.rs

-11
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,3 @@ impl ExportChainSpecCmd {
6666
Ok(())
6767
}
6868
}
69-
impl CliConfiguration for ExportChainSpecCmd {
70-
// If ExportChainSpecCmd doesn’t have shared_params, you must provide some implementation.
71-
fn shared_params(&self) -> &SharedParams {
72-
unimplemented!("ExportChainSpecCmd does not implement shared_params")
73-
}
74-
75-
// Implement the chain_id method to return the chain identifier.
76-
fn chain_id(&self, _is_dev: bool) -> Result<String> {
77-
Ok(self.chain.clone())
78-
}
79-
}

templates/minimal/node/src/cli.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ pub enum Subcommand {
5959
Key(sc_cli::KeySubcommand),
6060

6161
/// Build a chain specification.
62-
/// #[deprecated( note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead")]
62+
/// DEPRECATED: `build-spec` command will be removed after 1/04/2026. Use `export-chain-spec` command instead.
6363
#[deprecated(
6464
note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead"
6565
)]

templates/parachain/node/src/cli.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use std::path::PathBuf;
66
#[derive(Debug, clap::Subcommand)]
77
pub enum Subcommand {
88
/// Build a chain specification.
9-
/// #[deprecated( note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead")]
9+
/// DEPRECATED: `build-spec` command will be removed after 1/04/2026. Use `export-chain-spec` command instead.
1010
#[deprecated(
1111
note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead"
1212
)]

templates/solochain/node/src/cli.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ pub enum Subcommand {
1515
Key(sc_cli::KeySubcommand),
1616

1717
/// Build a chain specification.
18-
/// #[deprecated( note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead")]
18+
/// DEPRECATED: `build-spec` command will be removed after 1/04/2026. Use `export-chain-spec` command instead.
1919
#[deprecated(
2020
note = "build-spec command will be removed after 1/04/2026. Use export-chain-spec command instead"
2121
)]

0 commit comments

Comments
 (0)