Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pallet nomination pool to support Block Number Provider #6715

Merged
merged 8 commits into from
Feb 8, 2025
Merged

Update pallet nomination pool to support Block Number Provider #6715

merged 8 commits into from
Feb 8, 2025

Conversation

dharjeezy
Copy link
Contributor

@dharjeezy dharjeezy commented Dec 1, 2024 •
edited
Loading

This PR introduces BlockNumberProvider config for the nomination pool pallet.
closes part of #6297

Polkadot address: 12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW

@dharjeezy dharjeezy requested a review from a team as a code owner December 1, 2024 02:12
gui1117
gui1117 approved these changes Dec 1, 2024
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me,

gui1117
gui1117 reviewed Dec 2, 2024
View reviewed changes
@gui1117 gui1117 added the T2-pallets This PR/Issue is related to a particular pallet. label Dec 2, 2024
@dharjeezy dharjeezy mentioned this pull request Jan 14, 2025
Open
muharem
muharem approved these changes Jan 24, 2025
View reviewed changes
prdoc/pr_6715.prdoc Outdated
- audience: Runtime Dev
description: |
This PR makes the block number provider used in the nomination pool pallet configurable. Before this PR, nomination pool pallet always used the system block number,
with this PR some runtime can opt to use the relay chain block number instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as in the other PR.

@dharjeezy
Merge remote-tracking branch 'origin/master' into dami/pallet_nominat…
3e9f335 
…ion_pool_block_number_provider

# Conflicts:
#	substrate/frame/nomination-pools/test-transfer-stake/src/mock.rs
@dharjeezy
nit
b432eef
@muharem
Copy link
Contributor

muharem commented Feb 7, 2025

@dharjeezy please remove this empty file - substrate/frame/nomination-pools/test-transfer-stake/src/mock.rs

@muharem muharem added this pull request to the merge queue Feb 8, 2025
Merged via the queue into paritytech:master with commit 10b77c9 Feb 8, 2025
198 of 205 checks passed
@gui1117 gui1117 mentioned this pull request Feb 11, 2025
Merged
@ggwpez
Copy link
Member

ggwpez commented Feb 11, 2025

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@dharjeezy Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

@dharjeezy
Copy link
Contributor Author

@dharjeezy Contributor did not properly post their account address.

Make sure the pull request description (or user bio) has: "{network} address: {address}".

i have updated my address @ggwpez

@ggwpez
Copy link
Member

ggwpez commented Feb 11, 2025

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@ggwpez A referendum for a small (20 DOT) tip was successfully submitted for @dharjeezy (12GyGD3QhT4i2JJpNzvMf96sxxBLWymz4RdGCxRH5Rj5agKW on polkadot).

Referendum number: 1431.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

clangenb pushed a commit to clangenb/polkadot-sdk that referenced this pull request Feb 19, 2025
@dharjeezy @clangenb
Update pallet nomination pool to support Block Number Provider (parit…
69610e9 
…ytech#6715)

This PR introduces BlockNumberProvider config for the nomination pool
pallet.
closes part of paritytech#6297
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@muharem muharem muharem approved these changes

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dharjeezy @muharem @ggwpez @gui1117