Allow configuration of worst case buy execution weight #7944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-buy-execution-weight
…-buy-execution-weight
|
I remember back in that PR there were a couple of things that needed to be analyzed:
|
|
CC @RomarQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
worst_case_buy_executionto the Config trait ofpallet-xcm-benchmarkswith a default implementation that mimics the code that existed previous to this PR.Rationale: not allowing to set the
WeightLimitand theFeeAssetmight mean that we dont benchmark the worst case, as withWeightLimit::UnlimitedtheTraderdoes not even execute:polkadot-sdk/polkadot/xcm/xcm-executor/src/lib.rs
Line 833 in c01dbeb
The new configurable function allows projects to customize the parameters with which the benchmark is run to make sure they account for the worst-case scenario
This is very likely the case of the assethub system chain, with several traders being analyzed and possibly several reads being made:
polkadot-sdk/cumulus/parachains/runtimes/assets/asset-hub-rococo/src/xcm_config.rs
Line 403 in 38d2fa8