ci: Migrate from istanbul to nyc; add lint job to CI (#225)

Author: vahidalizad

.github/workflows/ci.yml

@@ -7,27 +7,53 @@ on:
     branches:
       - '**'
 jobs:
-  test:
+  lint:
+    name: Lint
+    timeout-minutes: 15
     runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          cache: npm
+      - name: Install dependencies
+        run: npm ci
+      - name: Lint
+        run: npm run lint
+  test:
     strategy:
       matrix:
-        node: [ '14', '16', '18' ]
-    timeout-minutes: 30
-    env:
-      COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
+        include:
+          - name: Node.js 14
+            NODE_VERSION: 14
+          - name: Node.js 16
+            NODE_VERSION: 16
+          - name: Node.js 18
+            NODE_VERSION: 18
+      fail-fast: false
+    name: ${{ matrix.name }}
+    timeout-minutes: 15
+    runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
-      - name: Use Node.js
-        uses: actions/setup-node@v2
+      - uses: actions/checkout@v4
+      - name: Use Node.js ${{ matrix.NODE_VERSION }}
+        uses: actions/setup-node@v4
         with:
-          node-version: ${{ matrix.node }}
-      - name: Cache Node.js modules
-        uses: actions/cache@v2
+          node-version: ${{ matrix.NODE_VERSION }}
+          cache: npm
+      - name: Install dependencies
+        run: npm ci
+      - name: Run tests
+        run: npm run test
+      - name: Upload code coverage
+        uses: codecov/codecov-action@v4
         with:
-          path: ~/.npm
-          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
-          restore-keys: |
-              ${{ runner.os }}-node-
-      - run: npm ci
-      - run: npm run test
-      - run: ./node_modules/.bin/codecov
+          fail_ci_if_error: false
+          token: ${{ secrets.CODECOV_TOKEN }}
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true

.gitignore

@@ -12,6 +12,7 @@ pids
 lib-cov
 
 # Coverage directory used by tools like istanbul
+.nyc_output
 coverage
 
 # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)

.nycrc

@@ -0,0 +1,13 @@
+{
+  "all": true,
+  "reporter": [
+    "lcov",
+    "text-summary"
+  ],
+  "include": [
+    "src/**/*.js"
+  ],
+  "exclude": [
+    "**/spec/**"
+  ]
+}

config/default.json

@@ -0,0 +1,18 @@
+{
+  "accessKey": "accessKey",
+  "secretKey": "secretKey",
+  "insufficientOptions": {
+    "accessKey": "accessKey",
+    "secretKey": "secretKey"
+  },
+  "bucket": "bucket",
+  "objectWithBucket": {
+    "bucket": "bucket"
+  },
+  "emptyObject": {},
+  "paramsObjectWBucket": {
+    "params": {
+      "Bucket": "bucket"
+    }
+  }
+}

package-lock.json

@@ -5,7 +5,7 @@
   "main": "index.js",
   "scripts": {
     "pretest": "npm run lint",
-    "test": "NODE_ENV=test NODE_CONFIG_DIR=./spec/config istanbul cover -x **/spec/** jasmine --captureExceptions",
+    "test": "nyc jasmine",
     "lint": "eslint --cache ./",
     "lint:fix": "eslint --fix --cache ./"
   },
@@ -39,7 +39,7 @@
     "eslint": "7.13.0",
     "eslint-config-airbnb-base": "14.2.1",
     "eslint-plugin-import": "2.22.1",
-    "istanbul": "0.4.5",
+    "nyc": "17.1.0",
     "jasmine": "3.5.0",
     "parse": "3.3.1",
     "parse-server-conformance-tests": "1.0.0",