Merge pull request #17 from piotr-oles/fix/dont-debug-production-build

fix: don't debug production build

Author: piotr-oles

README.md

@@ -333,11 +333,11 @@ Options passed to the [AssemblyScript compiler](https://www.assemblyscript.org/c
 
 | Name             | Type     | Description |
 |------------------|----------| ----------- |
-| `debug`          | boolean  | Enables debug information in emitted binaries. |
-| `optimizeLevel`  | number   | How much to focus on optimizing code. [0-3] |
-| `shrinkLevel`    | number   | How much to focus on shrinking code size. [0-2] |
+| `debug`          | boolean  | Enables debug information in emitted binaries, enabled by default in webpack development mode. |
+| `optimizeLevel`  | number   | How much to focus on optimizing code, 3 by default. [0-3] |
+| `shrinkLevel`    | number   | How much to focus on shrinking code size, 1 by default. [0-2] |
 | `coverage`       | boolean  | Re-optimizes until no further improvements can be made. |
-| `noAssert`       | boolean  | Replaces assertions with just their value without trapping. |
+| `noAssert`       | boolean  | Replaces assertions with just their value without trapping, enabled by default in webpack production mode. |
 | `importMemory`   | boolean  | Imports the memory provided as 'env.memory'. |
 | `noExportMemory` | boolean  | Does not export the memory as 'memory'. |
 | `initialMemory`  | number   | Sets the initial memory size in pages. |

src/loader/index.ts

@@ -5,7 +5,7 @@ import { getOptions, interpolateName, OptionObject } from "loader-utils";
 import { validate } from "schema-utils";
 import { Schema } from "schema-utils/declarations/validate";
 import { createCompilerHost } from "./compiler-host";
-import { mapAscOptionsToArgs } from "./options";
+import { mapAscOptionsToArgs, Options } from "./options";
 import { AssemblyScriptError } from "./error";
 import schema from "./schema.json";
 import { addErrorToModule, addWarningToModule } from "./webpack";
@@ -43,11 +43,15 @@ function loader(this: any, buffer: Buffer) {
     ...userAscOptions
   } = options as LoaderOptions & CompilerOptions;
 
-  const ascOptions = {
+  const ascOptions: Options = {
     // default options
     // when user imports wasm with webassembly type, it's not possible to pass env
     runtime: module.type?.startsWith("webassembly") ? "stub" : "incremental",
     exportRuntime: !module.type?.startsWith("webassembly"),
+    debug: this.mode === "development",
+    optimizeLevel: 3,
+    shrinkLevel: 1,
+    noAssert: this.mode === "production",
     // user options
     ...userAscOptions,
   };
@@ -91,6 +95,10 @@ function loader(this: any, buffer: Buffer) {
 
   const host = createCompilerHost(this);
 
+  if (shouldGenerateSourceMap) {
+    ascOptions.sourceMap = true;
+  }
+
   const args = [
     path.basename(this.resourcePath),
     "--baseDir",
@@ -99,9 +107,6 @@ function loader(this: any, buffer: Buffer) {
     outFileName,
     ...mapAscOptionsToArgs(ascOptions),
   ];
-  if (shouldGenerateSourceMap) {
-    args.push("--sourceMap", "--debug");
-  }
   if (bind && name.endsWith(".wasm")) {
     // add required by as-bind file to compilation
     args.unshift(require.resolve("as-bind/lib/assembly/as-bind.ts"));

src/loader/options.ts

@@ -22,4 +22,4 @@ function mapAscOptionsToArgs(options: Options): string[] {
   return args;
 }
 
-export { mapAscOptionsToArgs };
+export { mapAscOptionsToArgs, Options };