feat: drop support for webpack 4 (#28)

Webpack 5 is currently a standard, and AssemblyScript targets modern stack.

Author: piotr-oles

README.md

@@ -14,7 +14,7 @@
 ## Installation
 
 This loader requires [AssemblyScript ~0.18](https://github.com/AssemblyScript/assemblyscript), 
-Node.js >= 12 and [webpack 4 or webpack 5](https://github.com/webpack/webpack)
+Node.js >= 12 and [webpack 5](https://github.com/webpack/webpack)
 
 ```sh
 # with npm

package.json

@@ -26,7 +26,7 @@
   ],
   "peerDependencies": {
     "assemblyscript": "^0.19.0",
-    "webpack": "^4.0.0 || ^5.0.0"
+    "webpack": "^5.0.0"
   },
   "dependencies": {
     "@assemblyscript/loader": "^0.19.0",

src/loader/index.ts

@@ -8,12 +8,7 @@ import { createCompilerHost } from "./compiler-host";
 import { mapAscOptionsToArgs, Options } from "./options";
 import { AssemblyScriptError } from "./error";
 import * as schema from "./schema.json";
-import {
-  addErrorToModule,
-  addWarningToModule,
-  isModuleCompiledToWasm,
-  markModuleAsCompiledToWasm,
-} from "./webpack";
+import { isModuleCompiledToWasm, markModuleAsCompiledToWasm } from "./webpack";
 
 const SUPPORTED_EXTENSIONS = [".wasm", ".js"];
 
@@ -151,9 +146,9 @@ function loader(this: any, content: string, map?: any, meta?: any) {
             );
 
             if (diagnostic.category === DiagnosticCategory.ERROR) {
-              addErrorToModule(module, error);
+              module.addError(error);
             } else {
-              addWarningToModule(module, error);
+              module.addWarning(error);
             }
           });
           const errorDiagnostics = diagnostics.filter(

src/loader/webpack.ts

@@ -1,36 +1,5 @@
 import * as webpack from "webpack";
 
-interface CompatibleWebpackModule {
-  addWarning?(warning: Error): void;
-  addError?(error: Error): void;
-  warnings: Error[];
-  errors: Error[];
-}
-
-/**
- * Add warning to module.
- * Supports webpack 4 and webpack 5.
- */
-function addWarningToModule(module: CompatibleWebpackModule, error: Error) {
-  if (typeof module.addWarning === "function") {
-    module.addWarning(error);
-  } else {
-    module.warnings.push(error);
-  }
-}
-
-/**
- * Add error to module.
- * Supports webpack 4 and webpack 5.
- */
-function addErrorToModule(module: CompatibleWebpackModule, error: Error) {
-  if (typeof module.addError === "function") {
-    module.addError(error);
-  } else {
-    module.errors.push(error);
-  }
-}
-
 function markModuleAsCompiledToWasm(module: webpack.Module) {
   module.buildMeta.asLoaderCompiledToWasm = true;
 }
@@ -42,9 +11,4 @@ function isModuleCompiledToWasm(module: webpack.Module): boolean {
   );
 }
 
-export {
-  addWarningToModule,
-  addErrorToModule,
-  markModuleAsCompiledToWasm,
-  isModuleCompiledToWasm,
-};
+export { markModuleAsCompiledToWasm, isModuleCompiledToWasm };

test/e2e/fixtures/main/package.json

@@ -13,7 +13,7 @@
     "assemblyscript": "0.19.10",
     "ts-loader": "8.0.17",
     "typescript": "4.2.2",
-    "webpack": "4.46.0",
+    "webpack": "5.24.2",
     "webpack-cli": "4.5.0"
   },
   "engines": {