chore: handle fallback case, test for assets

Author: digitalsadhu

lib/http-outgoing.js

@@ -308,7 +308,10 @@ export default class PodletClientHttpOutgoing extends PassThrough {
     set hintsReceived(value) {
         this.#hintsReceived = value;
         if (this.#hintsReceived) {
-            this.#incoming.hints.addReceivedHint(this.#name);
+            this.#incoming?.hints?.addReceivedHint(this.#name, {
+                js: this.js,
+                css: this.css,
+            });
         }
     }
 
@@ -349,6 +352,8 @@ export default class PodletClientHttpOutgoing extends PassThrough {
         this.css = this.#manifest._css;
         this.push(null);
         this.#isFallback = true;
+        // assume the hints from the podlet have failed and fallback assets will be used
+        this.hintsReceived = true;
     }
 
     writeEarlyHints(cb = () => {}) {

tests/resource.test.js

@@ -852,10 +852,42 @@ tap.test(
     },
 );
 
+tap.test(
+    'Resource().fetch - hints complete event emitted once all early hints received - resource is failing',
+    async (t) => {
+        t.plan(3);
+        const server = new PodletServer({
+            version: '1.0.0',
+            assets: {
+                js: '/foo/bar.js',
+                css: '/foo/bar.css',
+            },
+            content: '/does/not/exist',
+        });
+        const service = await server.listen();
+
+        const client = new Client({ name: 'podiumClient' });
+        const component = client.register(service.options);
+
+        const incoming = new HttpIncoming({ headers: {} });
+
+        incoming.hints.on('complete', (assets) => {
+            t.ok(true);
+            t.equal(assets.js.length, 1);
+            t.equal(assets.css.length, 1);
+            t.end();
+        });
+
+        await component.fetch(incoming);
+
+        await server.close();
+    },
+);
+
 tap.test(
     'Resource().fetch - hints complete event emitted once all early hints received - multiple resource components',
     async (t) => {
-        t.plan(1);
+        t.plan(3);
         const server1 = new PodletServer({
             name: 'one',
             version: '1.0.0',
@@ -891,7 +923,9 @@ tap.test(
 
         const incoming = new HttpIncoming({ headers: {} });
 
-        incoming.hints.on('complete', () => {
+        incoming.hints.on('complete', (assets) => {
+            t.equal(assets.js.length, 3);
+            t.equal(assets.css.length, 3);
             t.ok(true);
             t.end();
         });