add test for unknown duration

Author: wasaga

internal/provider/convert.go

@@ -50,7 +50,6 @@ func FromStringMap(m map[string]string) types.Map {
 
 // ToStringList converts a types.List to Settings_StringList and handles diagnostics internally
 func ToStringList(ctx context.Context, dst **pb.Settings_StringList, list types.List, diagnostics *diag.Diagnostics) {
-	// Handle null list case first
 	if list.IsNull() {
 		*dst = nil
 		return
@@ -91,7 +90,7 @@ func ToStringSlice(ctx context.Context, dst *[]string, list types.List, diagnost
 
 // ToDuration converts a types.String containing a duration to a durationpb.Duration and handles diagnostics internally
 func ToDuration(dst **durationpb.Duration, src timetypes.GoDuration, diagnostics *diag.Diagnostics) {
-	if src.IsNull() {
+	if src.IsNull() || src.IsUnknown() {
 		*dst = nil
 		return
 	}

internal/provider/convert_test.go

@@ -86,6 +86,56 @@ func TestFromDurationP(t *testing.T) {
 	}
 }
 
+func TestToDuration(t *testing.T) {
+	tests := []struct {
+		name        string
+		input       timetypes.GoDuration
+		expected    *durationpb.Duration
+		expectError bool
+	}{
+		{
+			name:     "null duration",
+			input:    timetypes.NewGoDurationNull(),
+			expected: nil,
+		},
+		{
+			name:     "unknown duration",
+			input:    timetypes.NewGoDurationUnknown(),
+			expected: nil,
+		},
+		{
+			name:     "zero duration",
+			input:    timetypes.NewGoDurationValueFromStringMust("0s"),
+			expected: durationpb.New(0),
+		},
+		{
+			name:     "normal duration",
+			input:    timetypes.NewGoDurationValueFromStringMust("1h1m0s"),
+			expected: durationpb.New(time.Hour + time.Minute),
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			var result *durationpb.Duration
+			diagnostics := diag.Diagnostics{}
+			provider.ToDuration(&result, tt.input, &diagnostics)
+
+			if tt.expectError {
+				assert.True(t, diagnostics.HasError())
+				return
+			}
+
+			assert.False(t, diagnostics.HasError())
+			if tt.expected == nil {
+				assert.Nil(t, result)
+			} else {
+				assert.Equal(t, tt.expected.AsDuration(), result.AsDuration())
+			}
+		})
+	}
+}
+
 func TestToStringList(t *testing.T) {
 	ctx := context.Background()
 	tests := []struct {