make lint

Author: wasaga

internal/provider/jwt_group_filter.go

@@ -39,7 +39,6 @@ var (
 func JWTGroupsFilterFromPB(
 	dst *types.Object,
 	src *pb.JwtGroupsFilter,
-	diags *diag.Diagnostics,
 ) {
 	if src == nil {
 		*dst = types.ObjectNull(jwtGroupsFilterSchemaAttr)
@@ -69,7 +68,7 @@ func JWTGroupsFilterToPB(
 	diags *diag.Diagnostics,
 ) {
 	if src.IsNull() {
-		dst = nil
+		*dst = nil
 		return
 	}
 

internal/provider/jwt_group_filter_test.go

@@ -53,10 +53,8 @@ func TestJWTGroupsFilterFromPB(t *testing.T) {
 
 	for _, tc := range tests {
 		t.Run(tc.name, func(t *testing.T) {
-			var diags diag.Diagnostics
 			var result types.Object
-			JWTGroupsFilterFromPB(&result, tc.input, &diags)
-			assert.False(t, diags.HasError())
+			JWTGroupsFilterFromPB(&result, tc.input)
 			diff := cmp.Diff(tc.expected, result)
 			assert.Empty(t, diff)
 		})

internal/provider/route_model.go

@@ -149,7 +149,7 @@ func ConvertRouteFromPB(
 	dst.IDPClientID = types.StringPointerValue(src.IdpClientId)
 	dst.IDPClientSecret = types.StringPointerValue(src.IdpClientSecret)
 	dst.ShowErrorDetails = types.BoolValue(src.ShowErrorDetails)
-	JWTGroupsFilterFromPB(&dst.JWTGroupsFilter, src.JwtGroupsFilter, &diagnostics)
+	JWTGroupsFilterFromPB(&dst.JWTGroupsFilter, src.JwtGroupsFilter)
 
 	return diagnostics
 }

internal/provider/settings_model.go

@@ -225,7 +225,7 @@ func ConvertSettingsFromPB(
 	dst.TimeoutIdle = FromDuration(src.TimeoutIdle)
 	dst.TimeoutRead = FromDuration(src.TimeoutRead)
 	dst.TimeoutWrite = FromDuration(src.TimeoutWrite)
-	JWTGroupsFilterFromPB(&dst.JWTGroupsFilter, src.JwtGroupsFilter, &diagnostics)
+	JWTGroupsFilterFromPB(&dst.JWTGroupsFilter, src.JwtGroupsFilter)
 
 	return diagnostics
 }