chore: correct gorelease config

Signed-off-by: Oliver Bähler <[email protected]>

Author: oliverbaehler

charts/cortex-proxy/README.md

@@ -107,7 +107,7 @@ The following Values are available for this chart.
 | monitoring.enabled | bool | `false` | Enable Monitoring of the Operator |
 | monitoring.rules.annotations | object | `{}` | Assign additional Annotations |
 | monitoring.rules.enabled | bool | `true` | Enable deployment of PrometheusRules |
-| monitoring.rules.groups | list | `[{"name":"TranslatorAlerts","rules":[{"alert":"TranslatorNotReady","annotations":{"description":"The Translator {{ $labels.name }} has been in a NotReady state for over 5 minutes.","summary":"Translator {{ $labels.name }} is not ready"},"expr":"cca_translator_condition{status=\"NotReady\"} == 1","for":"5m","labels":{"severity":"warning"}}]}]` | Prometheus Groups for the rule |
+| monitoring.rules.groups | list | `[{"alert":"CortexProxyTooMany500s","annotations":{"description":"Too many 5XXs","summary":"More than 5% of all requests returned 5XX, this requires your attention"},"expr":"100 * ( sum( timeseries_request_duration_seconds{code=~\"5.+\"} ) / sum(timeseries_request_duration_seconds) ) > 5","for":"5m","labels":{"severity":"warning"}},{"alert":"CortexProxyTooMany400s","annotations":{"description":"Too many 4XXs","summary":"More than 5% of all requests returned 4XX, this requires your attention"},"expr":"100 * ( sum( timeseries_request_duration_seconds{status=~\"4.+\"} ) / sum(timeseries_request_duration_seconds) ) > 5","for":"5m","labels":{"severity":"warning"}}]` | Prometheus Groups for the rule |
 | monitoring.rules.labels | object | `{}` | Assign additional labels |
 | monitoring.rules.namespace | string | `""` | Install the rules into a different Namespace, as the monitoring stack one (default: the release one) |
 | monitoring.serviceMonitor.annotations | object | `{}` | Assign additional Annotations |

charts/cortex-proxy/ci/monitoring-values.yaml

@@ -0,0 +1,2 @@
+image:
+  pullPolicy: Never

charts/cortex-proxy/values.schema.json

@@ -185,44 +185,33 @@
                         "groups": {
                             "items": {
                                 "properties": {
-                                    "name": {
+                                    "alert": {
                                         "type": "string"
                                     },
-                                    "rules": {
-                                        "items": {
-                                            "properties": {
-                                                "alert": {
-                                                    "type": "string"
-                                                },
-                                                "annotations": {
-                                                    "properties": {
-                                                        "description": {
-                                                            "type": "string"
-                                                        },
-                                                        "summary": {
-                                                            "type": "string"
-                                                        }
-                                                    },
-                                                    "type": "object"
-                                                },
-                                                "expr": {
-                                                    "type": "string"
-                                                },
-                                                "for": {
-                                                    "type": "string"
-                                                },
-                                                "labels": {
-                                                    "properties": {
-                                                        "severity": {
-                                                            "type": "string"
-                                                        }
-                                                    },
-                                                    "type": "object"
-                                                }
+                                    "annotations": {
+                                        "properties": {
+                                            "description": {
+                                                "type": "string"
                                             },
-                                            "type": "object"
+                                            "summary": {
+                                                "type": "string"
+                                            }
                                         },
-                                        "type": "array"
+                                        "type": "object"
+                                    },
+                                    "expr": {
+                                        "type": "string"
+                                    },
+                                    "for": {
+                                        "type": "string"
+                                    },
+                                    "labels": {
+                                        "properties": {
+                                            "severity": {
+                                                "type": "string"
+                                            }
+                                        },
+                                        "type": "object"
                                     }
                                 },
                                 "type": "object"

charts/cortex-proxy/values.yaml

@@ -220,17 +220,22 @@ monitoring:
     annotations: {}
     # -- Prometheus Groups for the rule
     groups:
-    - name: TranslatorAlerts
-      rules:
-        - alert: TranslatorNotReady
-          expr: cca_translator_condition{status="NotReady"} == 1
-          for: 5m
-          labels:
-            severity: warning
-          annotations:
-            summary: "Translator {{ $labels.name }} is not ready"
-            description: "The Translator {{ $labels.name }} has been in a NotReady state for over 5 minutes."
-
+      - alert: CortexProxyTooMany500s
+        expr: 100 * ( sum( timeseries_request_duration_seconds{code=~"5.+"} ) / sum(timeseries_request_duration_seconds) ) > 5
+        for: 5m
+        labels:
+          severity: warning
+        annotations:
+          description: Too many 5XXs
+          summary: More than 5% of all requests returned 5XX, this requires your attention
+      - alert: CortexProxyTooMany400s
+        expr: 100 * ( sum( timeseries_request_duration_seconds{status=~"4.+"} ) / sum(timeseries_request_duration_seconds) ) > 5
+        for: 5m
+        labels:
+          severity: warning
+        annotations:
+          description: Too many 4XXs
+          summary: More than 5% of all requests returned 4XX, this requires your attention
   # ServiceMonitor
   serviceMonitor:
     # -- Enable ServiceMonitor