Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeployKey as valid actor in ruleset actors #854

Open
michael-tribe opened this issue Jan 20, 2025 · 2 comments
Open

Add DeployKey as valid actor in ruleset actors #854

michael-tribe opened this issue Jan 20, 2025 · 2 comments
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec

Comments

@michael-tribe
Copy link

Describe what happened

DeployKey is a valid actor for (repository) ruleset bypass actors, see similar issue in TF where this has been updated: integrations/terraform-provider-github#2254

Sample program

pulumi up

Log output

has a problem: expected bypass_actors.0.actor_type to be one of ["RepositoryRole" "Team" "Integration" "OrganizationAdmin"], got DeployKey.

Affected Resource(s)

No response

Output of pulumi about

CLI
Version 3.145.0
Go Version go1.23.4
Go Compiler gc

Plugins
KIND NAME VERSION
resource aws 6.66.2
resource awsx 2.19.0
resource docker 4.5.8
resource eks 3.7.0
resource github 6.5.0
resource kubernetes 4.19.0
language python 3.145.0
resource random 4.16.8
resource tls 5.0.10

Host
OS debian
Version 12.8
Arch aarch64

...

Found no pending operations associated with platform.vcs.github

Backend
Name 8a286384bcbb
URL s3://[redacted]
User vscode
Organizations
Token type personal

Dependencies:
NAME VERSION
mypy 1.14.1
pre-commit-uv 4.1.4
pulumi_awsx 2.19.0
pulumi_eks 3.7.0
pulumi_github 6.5.0
pulumi_random 4.16.8
pulumi_tls 5.0.10
python-dotenv 1.0.1
ruff 0.9.0
setuptools 75.8.0
types-PyYAML 6.0.12.20241230

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@michael-tribe michael-tribe added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jan 20, 2025
@guineveresaenger
Copy link
Contributor

Hi @michael-tribe - thank you for letting us know about this feature!

We'll be having it available for you shortly after the feature is included in an upstream release. It's looking like there's an open pull request; once that's merged and in a tagged release, we'll pull in those changes here.

@guineveresaenger guineveresaenger added awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). and removed needs-triage Needs attention from the triage team labels Jan 21, 2025
@michael-tribe
Copy link
Author

Awesome, thanks for the prompt response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-upstream The issue cannot be resolved without action in another repository (may be owned by Pulumi). kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

2 participants