Skip to content

Commit b9e8161

Browse files
authored
Tidy up trailing whitespace in gem post_install_message (#3689)
Previously, the post_install_message contained trailing whitespace on its last line such that the user's console prompt would be shifted to the right in an unusual way. Now, follow shell conventions and finish the message with the a final newline and nothing else. This change also left aligns the message like other Ruby gem post_install_messages do. Before: ``` $ bundle install ... Post-install message from rails_admin: ### Upgrading RailsAdmin from 2.x.x to 3.x.x ### Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed. Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app. For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md jon@localhost$ ``` After: ``` \### Upgrading RailsAdmin from 2.x.x to 3.x.x ### Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed. Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app. For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md Successfully installed rails_admin-3.1.2 jon@localhost$ ```
1 parent 6399cd9 commit b9e8161

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

rails_admin.gemspec

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@ Gem::Specification.new do |spec|
2525
spec.required_rubygems_version = '>= 1.8.11'
2626
spec.summary = 'Admin for Rails'
2727
spec.version = RailsAdmin::Version
28-
spec.post_install_message = '
28+
spec.post_install_message = <<~MSG
2929
### Upgrading RailsAdmin from 2.x.x to 3.x.x ###
3030
3131
Due to introduction of Webpack/Webpacker support, some additional dependencies and configuration will be needed.
3232
Running `bin/rails g rails_admin:install` will suggest required changes, based on the current setup of your app.
3333
3434
For a complete list of changes, see https://github.com/railsadminteam/rails_admin/blob/master/CHANGELOG.md
35-
'
35+
MSG
3636
end

0 commit comments

Comments
 (0)