Skip to content

Commit 5ba9bb7

Browse files
author
John Dennis
committedOct 30, 2015
Role maybe unknown when assertion consumer url is looked up
Replace the call to lasso_provider_get_metadata_one() with lasso_provider_get_metadata_one_for_role() so that we can exlicitly pass the LASSO_PROVIDER_ROLE_SP role. The former call obtains the role from the provider object and then calls lasso_provider_get_metadata_one_for_role() using that role. However the role will not have been set in the provider until the first request is processed. This means the first time we call this routine it won't work correctly because the role will not have been set yet, by explicitly passing the role we avoid this problem. Signed-off-by: John Dennis <jdennis@redhat.com>
1 parent cee415c commit 5ba9bb7

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed
 

‎auth_mellon_util.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -1827,7 +1827,9 @@ char *am_get_assertion_consumer_service_by_binding(LassoProvider *provider, cons
18271827
}
18281828

18291829
if (selected_descriptor) {
1830-
url = lasso_provider_get_metadata_one(provider, selected_descriptor);
1830+
url = lasso_provider_get_metadata_one_for_role(provider,
1831+
LASSO_PROVIDER_ROLE_SP,
1832+
selected_descriptor);
18311833
}
18321834

18331835
lasso_release_list_of_strings(descriptors);

0 commit comments

Comments
 (0)
Please sign in to comment.