Skip to content

Commit f0edde6

Browse files
committed
feat(footer): link privacy notice to configured URL (#393)
Closes #392
1 parent 8d58277 commit f0edde6

File tree

6 files changed

+11
-360
lines changed

6 files changed

+11
-360
lines changed

reana-ui/src/components/App.js

-2
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import OAuthSignin from "~/pages/signin/OAuthSignin";
3333
import WorkflowList from "~/pages/workflowList/WorkflowList";
3434
import WorkflowDetails from "~/pages/workflowDetails/WorkflowDetails";
3535
import Profile from "~/pages/profile/Profile";
36-
import PrivacyNotice from "~/pages/privacyNotice/PrivacyNotice";
3736
import Status from "~/pages/status/Status";
3837
import LaunchOnReana from "~/pages/launchOnReana/LaunchOnReana";
3938
import NotFound from "~/pages/error/NotFound";
@@ -81,7 +80,6 @@ export default function App() {
8180
}
8281
/>
8382
<Route path="/confirm/:token" element={<Confirm />} />
84-
<Route path="/privacy-notice" element={<PrivacyNotice />} />
8583
<Route path="/signin_callback" element={<OAuthSignin />} />
8684
<Route
8785
path="/"

reana-ui/src/components/Footer.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,15 @@ export default function Footer() {
2020
const config = useSelector(getConfig);
2121
return (
2222
<footer className={styles["footer-bottom"]}>
23-
<span>
24-
{config.cernRopo && (
25-
<Link to="/privacy-notice">
23+
<span className={styles["links"]}>
24+
{config.privacyNoticeURL && (
25+
<a
26+
href={config.privacyNoticeURL}
27+
target="_blank"
28+
rel="noopener noreferrer"
29+
>
2630
<Icon name="privacy"></Icon> Privacy notice
27-
</Link>
31+
</a>
2832
)}
2933
</span>
3034
<span className={styles["links"]}>

reana-ui/src/components/Footer.module.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
height: 60px;
2020
color: $gray;
2121

22-
.links > a {
22+
.links > a:not(:first-child) {
2323
margin-left: 1em;
2424
}
2525
}

reana-ui/src/pages/privacyNotice/PrivacyNotice.js

-335
This file was deleted.

reana-ui/src/pages/privacyNotice/PrivacyNotice.module.scss

-16
This file was deleted.

0 commit comments

Comments
 (0)