Disaster recovery UI for Kubevirt VM - Discovered(Standalone)

Signed-off-by: Gowtham Shanmugasundaram <[email protected]>

Author: GowthamShanmugam

locales/en/plugin__odf-console.json

@@ -340,6 +340,7 @@
   "{{selected}} of {{total}} selected": "{{selected}} of {{total}} selected",
   "subscription-selector": "subscription-selector",
   "Select the subscriptions groups you wish to replicate via": "Select the subscriptions groups you wish to replicate via",
+  "Enroll virtual machine": "Enroll virtual machine",
   "Enroll managed application": "Enroll managed application",
   "Manage disaster recovery": "Manage disaster recovery",
   "<0>Application:</0> {applicationName} (Namespace: {applicationNamespace})": "<0>Application:</0> {applicationName} (Namespace: {applicationNamespace})",
@@ -349,6 +350,15 @@
   "Invalid label selector": "Invalid label selector",
   "The selected PVC label selector doesn't meet the label requirements. Choose a valid label selector or create one with the following requirements: {{ message }}": "The selected PVC label selector doesn't meet the label requirements. Choose a valid label selector or create one with the following requirements: {{ message }}",
   "Assign": "Assign",
+  "Protection name": "Protection name",
+  "A unique name to identify and manage this protection.": "A unique name to identify and manage this protection.",
+  "Protect this VM independently without associating it with an existing DR placement control.": "Protect this VM independently without associating it with an existing DR placement control.",
+  "Standalone": "Standalone",
+  "Add this VM to an existing DR placement control for consistent failover and recovery. This method is only available for discovered VMs.": "Add this VM to an existing DR placement control for consistent failover and recovery. This method is only available for discovered VMs.",
+  "Shared": "Shared",
+  "Protection type": "Protection type",
+  "Choose how you would like to protect this VM:": "Choose how you would like to protect this VM:",
+  "Shared protection is not available for managed VMs.": "Shared protection is not available for managed VMs.",
   "Delete": "Delete",
   "Select a placement": "Select a placement",
   "{{count}} selected_one": "{{count}} selected",
@@ -360,25 +370,28 @@
   "Application resource": "Application resource",
   "PVC label selector": "PVC label selector",
   "Add application resource": "Add application resource",
-  "{{count}} placements_one": "{{count}} placements",
-  "{{count}} placements_other": "{{count}} placements",
-  "Data policy": "Data policy",
+  "Protection type:": "Protection type:",
+  "Protection name:": "Protection name:",
+  "Policy": "Policy",
   "Policy name:": "Policy name:",
   "Clusters:": "Clusters:",
   "Replication type:": "Replication type:",
   "Sync interval:": "Sync interval:",
+  "{{count}} placements_one": "{{count}} placements",
+  "{{count}} placements_other": "{{count}} placements",
   "PVC details": "PVC details",
   "Application resource:": "Application resource:",
   "PVC label selector:": "PVC label selector:",
+  "Application already enrolled in disaster recovery": "Application already enrolled in disaster recovery",
+  "<0>This managed application namespace is already DR protected. You may have protected this namespace while enrolling discovered applications.</0><1>To see disaster recovery information for your applications, go to<1> Protected applications </1> under <3> Disaster Recovery </3>.</1>": "<0>This managed application namespace is already DR protected. You may have protected this namespace while enrolling discovered applications.</0><1>To see disaster recovery information for your applications, go to<1> Protected applications </1> under <3> Disaster Recovery </3>.</1>",
+  "No assigned disaster recovery policy found": "No assigned disaster recovery policy found",
+  "<0>You have not enrolled this application yet. To protect your application, click <1>Enroll application.</1></0>": "<0>You have not enrolled this application yet. To protect your application, click <1>Enroll application.</1></0>",
+  "Enroll application": "Enroll application",
+  "<0>You have not enrolled this virtual machine yet. To protect your virtual machine, click <1>Enroll virtual machine.</1></0>": "<0>You have not enrolled this virtual machine yet. To protect your virtual machine, click <1>Enroll virtual machine.</1></0>",
   "New policy assigned to application": "New policy assigned to application",
   "Remove disaster recovery": "Remove disaster recovery",
   "Your application will lose disaster recovery protection, preventing volume synchronization (replication) between clusters.": "Your application will lose disaster recovery protection, preventing volume synchronization (replication) between clusters.",
   "Disaster recovery removed successfully.": "Disaster recovery removed successfully.",
-  "Enroll application": "Enroll application",
-  "Application already enrolled in disaster recovery": "Application already enrolled in disaster recovery",
-  "No assigned disaster recovery policy found": "No assigned disaster recovery policy found",
-  "<0>This managed application namespace is already DR protected. You may have protected this namespace while enrolling discovered applications.</0><1>To see disaster recovery information for your applications, go to<1>Protected applications</1> under <3>Disaster Recovery</3>.</1>": "<0>This managed application namespace is already DR protected. You may have protected this namespace while enrolling discovered applications.</0><1>To see disaster recovery information for your applications, go to<1>Protected applications</1> under <3>Disaster Recovery</3>.</1>",
-  "You have not enrolled this application yet. To protect your application,": "You have not enrolled this application yet. To protect your application,",
   "Disaster recovery policy details": "Disaster recovery policy details",
   "Name: {{name}} ({{status}})": "Name: {{name}} ({{status}})",
   "Replication policy: {{replicationType}}, {{interval}} {{unit}}": "Replication policy: {{replicationType}}, {{interval}} {{unit}}",
@@ -418,7 +431,6 @@
   "{{appName}} is now successfully enrolled for disaster recovery protection.": "{{appName}} is now successfully enrolled for disaster recovery protection.",
   "For disaster recovery or replication details about ACM managed applications navigate to Applications overview page.": "For disaster recovery or replication details about ACM managed applications navigate to Applications overview page.",
   "Overall sync status": "Overall sync status",
-  "Policy": "Policy",
   "Cluster": "Cluster",
   "Edit configuration": "Edit configuration",
   "Update existing configuration in YAML view": "Update existing configuration in YAML view",
@@ -440,6 +452,7 @@
   "PersistentVolumeClaim": "PersistentVolumeClaim",
   "Review and assign": "Review and assign",
   "Review": "Review",
+  "Data policy": "Data policy",
   "Data Services": "Data Services",
   "In use: {{targetClusters}}": "In use: {{targetClusters}}",
   "Used: {{targetClusters}}": "Used: {{targetClusters}}",

packages/mco/components/discovered-application-wizard/enroll-discovered-application.spec.tsx

@@ -625,7 +625,7 @@ describe('Test review step', () => {
     await waitFor(async () => {
       expect(
         JSON.stringify(drpcObj) ===
-          '{"apiVersion":"ramendr.openshift.io/v1alpha1","kind":"DRPlacementControl","metadata":{"name":"my-name","namespace":"openshift-dr-ops"},"spec":{"preferredCluster":"east-1","protectedNamespaces":["namespace-1","namespace-2"],"pvcSelector":{},"kubeObjectProtection":{"captureInterval":"5m","recipeRef":{"name":"mock-recipe-1","namespace":"namespace-1"}},"drPolicyRef":{"name":"mock-policy-1","apiVersion":"ramendr.openshift.io/v1alpha1","kind":"DRPolicy"},"placementRef":{"name":"my-name-placement-1","namespace":"openshift-dr-ops","apiVersion":"cluster.open-cluster-management.io/v1beta1","kind":"Placement"}}}'
+          '{"apiVersion":"ramendr.openshift.io/v1alpha1","kind":"DRPlacementControl","metadata":{"name":"my-name","namespace":"openshift-dr-ops"},"spec":{"preferredCluster":"east-1","protectedNamespaces":["namespace-1","namespace-2"],"pvcSelector":{},"kubeObjectProtection":{"captureInterval":"5m","recipeRef":{"name":"mock-recipe-1","namespace":"namespace-1"},"recipeParameters":{}},"drPolicyRef":{"name":"mock-policy-1","apiVersion":"ramendr.openshift.io/v1alpha1","kind":"DRPolicy"},"placementRef":{"name":"my-name-placement-1","namespace":"openshift-dr-ops","apiVersion":"cluster.open-cluster-management.io/v1beta1","kind":"Placement"}}}'
       ).toBeTruthy();
     });
   });

packages/mco/components/discovered-application-wizard/utils/k8s-utils.ts

@@ -7,11 +7,7 @@ import {
   DISCOVERED_APP_NS,
   PROTECTED_APP_ANNOTATION,
 } from '@odf/mco/constants';
-import {
-  ACMPlacementKind,
-  DRPlacementControlKind,
-  DRPolicyKind,
-} from '@odf/mco/types';
+import { ACMPlacementKind, DRPlacementControlKind } from '@odf/mco/types';
 import { getName } from '@odf/shared/selectors';
 import { K8sResourceKind } from '@odf/shared/types';
 import { getAPIVersionForModel } from '@odf/shared/utils';
@@ -29,13 +25,14 @@ export const getDRPCKindObj = (props: {
   preferredCluster: string;
   namespaces: string[];
   protectionMethod: ProtectionMethodType;
-  drPolicy: DRPolicyKind;
+  drPolicyName: string;
   k8sResourceReplicationInterval: string;
   recipeName?: string;
   recipeNamespace?: string;
   k8sResourceLabelExpressions?: MatchExpression[];
   pvcLabelExpressions?: MatchExpression[];
   placementName: string;
+  recipeParameters?: Record<string, string[]>;
 }): DRPlacementControlKind => ({
   apiVersion: getAPIVersionForModel(DRPlacementControlModel),
   kind: DRPlacementControlModel.kind,
@@ -59,6 +56,7 @@ export const getDRPCKindObj = (props: {
               name: props.recipeName,
               namespace: props.recipeNamespace,
             },
+            recipeParameters: props.recipeParameters ?? {},
           }
         : {
             kubeObjectSelector: {
@@ -67,7 +65,7 @@ export const getDRPCKindObj = (props: {
           }),
     },
     drPolicyRef: {
-      name: getName(props.drPolicy),
+      name: props.drPolicyName,
       apiVersion: getAPIVersionForModel(DRPolicyModel),
       kind: DRPolicyModel.kind,
     },
@@ -81,7 +79,9 @@ export const getDRPCKindObj = (props: {
 });
 
 // Dummy placement for the discovered apps DRPC
-const getPlacementKindObj = (placementName: string): ACMPlacementKind => ({
+export const getPlacementKindObj = (
+  placementName: string
+): ACMPlacementKind => ({
   apiVersion: getAPIVersionForModel(ACMPlacementModel),
   kind: ACMPlacementModel.kind,
   metadata: {
@@ -130,7 +130,7 @@ export const createPromise = (
         recipeNamespace,
         k8sResourceLabelExpressions,
         pvcLabelExpressions,
-        drPolicy,
+        drPolicyName: getName(drPolicy),
         k8sResourceReplicationInterval,
         placementName,
       }),

packages/mco/components/discovered-application-wizard/wizard-steps/replication-step/replication-selection-helper.tsx

@@ -0,0 +1,190 @@
+import * as React from 'react';
+import {
+  MIN_VALUE,
+  normalizeSyncTimeValue,
+} from '@odf/mco/components/create-dr-policy/select-replication-type';
+import {
+  REPLICATION_DISPLAY_TEXT,
+  SYNC_SCHEDULE_DISPLAY_TEXT,
+} from '@odf/mco/constants';
+import { getDRPolicyStatus, parseSyncInterval } from '@odf/mco/utils';
+import { SingleSelectDropdown } from '@odf/shared/dropdown';
+import { FieldLevelHelp } from '@odf/shared/generic';
+import { useCustomTranslation } from '@odf/shared/useCustomTranslationHook';
+import { getValidatedProp } from '@odf/shared/utils';
+import { RequestSizeInput } from '@odf/shared/utils/RequestSizeInput';
+import { SelectOption } from '@patternfly/react-core/deprecated';
+import * as _ from 'lodash-es';
+import { TFunction } from 'react-i18next';
+import {
+  Form,
+  FormGroup,
+  FormHelperText,
+  FormSection,
+  HelperText,
+  HelperTextItem,
+  Text,
+  TextVariants,
+} from '@patternfly/react-core';
+
+// Get Policy Dropdown Options
+const getPolicyOptions = (policies: PolicyInfo[], t: TFunction) =>
+  policies.map((policy) => (
+    <SelectOption
+      key={policy.name}
+      value={policy.name}
+      description={
+        policy.schedulingInterval !== '0m'
+          ? t(
+              'Replication type: {{type}}, Interval: {{interval}}, Clusters: {{clusters}}',
+              {
+                type: REPLICATION_DISPLAY_TEXT(t).async,
+                interval: policy.schedulingInterval,
+                clusters: policy.drClusters.join(', '),
+              }
+            )
+          : t('Replication type: {{type}}, Clusters: {{clusters}}', {
+              type: REPLICATION_DISPLAY_TEXT(t).sync,
+              clusters: policy.drClusters.join(', '),
+            })
+      }
+    />
+  ));
+
+// Policy Selection Component
+const PolicySelection: React.FC<PolicySelectionProps> = ({
+  policy,
+  eligiblePolicies,
+  isValidationEnabled,
+  onChange,
+}) => {
+  const { t } = useCustomTranslation();
+  const translatedPolicyStatus = t('Status: {{status}}', {
+    status: getDRPolicyStatus(policy?.isValidated, t),
+  });
+
+  const policyValidated = getValidatedProp(
+    (isValidationEnabled && _.isEmpty(policy)) || !eligiblePolicies.length
+  );
+
+  const helperTextInvalid = !eligiblePolicies.length
+    ? t('No policy found')
+    : t('Required');
+  const helperText = !_.isEmpty(policy) && translatedPolicyStatus;
+
+  return (
+    <FormGroup
+      className="pf-v5-u-w-50"
+      fieldId="dr-policy-selection"
+      label={t('Disaster recovery policy')}
+      labelIcon={
+        <FieldLevelHelp>
+          {t('The policy sync interval is only applicable to volumes.')}
+        </FieldLevelHelp>
+      }
+      isRequired
+    >
+      <SingleSelectDropdown
+        id="dr-policy-dropdown"
+        placeholderText={t('Select a policy')}
+        selectedKey={policy?.name}
+        selectOptions={getPolicyOptions(eligiblePolicies, t)}
+        onChange={onChange}
+        validated={policyValidated}
+        isDisabled={!eligiblePolicies.length}
+      />
+      <FormHelperText>
+        <HelperText>
+          <HelperTextItem variant={policyValidated}>
+            {policyValidated === 'error' ? helperTextInvalid : helperText}
+          </HelperTextItem>
+        </HelperText>
+      </FormHelperText>
+    </FormGroup>
+  );
+};
+
+// Replication Selection Component
+export const ReplicationSelectionHelper: React.FC<
+  ReplicationSelectionHelperProps
+> = ({
+  eligiblePolicies,
+  policy,
+  k8sResourceReplicationInterval,
+  isValidationEnabled,
+  onK8sSyncIntervalChange,
+  onPolicyChange,
+}) => {
+  const { t } = useCustomTranslation();
+  const SyncScheduleFormat = SYNC_SCHEDULE_DISPLAY_TEXT(t);
+  const [unitVal, interval] = parseSyncInterval(k8sResourceReplicationInterval);
+
+  const setInterval = (props: { value: number; unit: string }) => {
+    onK8sSyncIntervalChange(
+      `${normalizeSyncTimeValue(props.value)}${props.unit}`
+    );
+  };
+
+  return (
+    <Form maxWidth="58rem">
+      <FormSection title={t('Volume and Kubernetes object replication')}>
+        <Text component={TextVariants.small}>
+          {t(
+            'Define where to sync or replicate your application volumes and Kubernetes object using a disaster recovery policy.'
+          )}
+        </Text>
+        <PolicySelection
+          policy={policy}
+          eligiblePolicies={eligiblePolicies}
+          isValidationEnabled={isValidationEnabled}
+          onChange={onPolicyChange}
+        />
+        <FormGroup
+          fieldId="k8s-resource-interval-selection"
+          label={t('Kubernetes object replication interval')}
+        >
+          <FormHelperText>
+            <HelperText>
+              <HelperTextItem>
+                {t('Define the interval for Kubernetes object replication')}
+              </HelperTextItem>
+            </HelperText>
+          </FormHelperText>
+          <RequestSizeInput
+            name={t('Replication interval')}
+            onChange={setInterval}
+            dropdownUnits={SyncScheduleFormat}
+            defaultRequestSizeUnit={unitVal}
+            defaultRequestSizeValue={interval.toString()}
+            minValue={MIN_VALUE}
+          />
+        </FormGroup>
+      </FormSection>
+    </Form>
+  );
+};
+
+// Common Policy Type
+export type PolicyInfo = {
+  name: string;
+  drClusters: string[];
+  schedulingInterval: string;
+  isValidated: boolean;
+};
+
+// Props
+type ReplicationSelectionHelperProps = {
+  eligiblePolicies: PolicyInfo[];
+  policy: PolicyInfo;
+  k8sResourceReplicationInterval: string;
+  isValidationEnabled: boolean;
+  onPolicyChange: (policyName: string) => void;
+  onK8sSyncIntervalChange: (syncInterval: string) => void;
+};
+
+type PolicySelectionProps = {
+  policy: PolicyInfo;
+  eligiblePolicies: PolicyInfo[];
+  isValidationEnabled: boolean;
+  onChange: (policyName: string) => void;
+};