Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Type Definitions #61

Open
jpeckAMC opened this issue Jan 21, 2025 · 0 comments
Open

Invalid Type Definitions #61

jpeckAMC opened this issue Jan 21, 2025 · 0 comments

Comments

@jpeckAMC
Copy link

Invalid Type Declarations for PhoneCall class

For PhoneCall objects, the contact property is declared to be Not Nullable. However in types.js, the contact property on the PhoneCall instance is not validated or set when the constructor's contact parameter is nullish.

Similarly, the callAttributes field for PhoneCall objects is declared to be Not Nullable. In the constructor for PhoneCall, the callAttributes property is set without checking or validating this parameter, meaning that PhoneCall.callAttributes can potentially be null or undefined.

The type declarations for PhoneCall in types.d.ts should be revised to either require non-null input to the contact and callAttributes parameters of the constructor, or to indicate these properties as nullable. This issue could also be present in other structures defined in the types.d.ts file as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant