remove template portal

Author: scttcper

src/lib/portal/dom-portal-host.ts

@@ -5,7 +5,7 @@ import {
   ApplicationRef,
   Injector,
 } from '@angular/core';
-import {BasePortalHost, ComponentPortal, TemplatePortal} from './portal';
+import {BasePortalHost, ComponentPortal} from './portal';
 
 
 /**
@@ -64,23 +64,6 @@ export class DomPortalHost extends BasePortalHost {
     return componentRef;
   }
 
-  attachTemplatePortal(portal: TemplatePortal): Map<string, any> {
-    let viewContainer = portal.viewContainerRef;
-    let viewRef = viewContainer.createEmbeddedView(portal.templateRef);
-
-    viewRef.rootNodes.forEach(rootNode => this._hostDomElement.appendChild(rootNode));
-
-    this.setDisposeFn((() => {
-      let index = viewContainer.indexOf(viewRef);
-      if (index !== -1) {
-        viewContainer.remove(index);
-      }
-    }));
-
-    // TODO(jelbourn): Return locals from view.
-    return new Map<string, any>();
-  }
-
   dispose(): void {
     super.dispose();
     if (this._hostDomElement.parentNode !== null) {

src/lib/portal/portal-errors.ts

@@ -30,15 +30,6 @@ export class MdPortalHostAlreadyDisposedError extends MdError {
   }
 }
 
-/** Exception thrown when attempting to attach an unknown portal type. */
-export class MdUnknownPortalTypeError extends MdError {
-  constructor() {
-      super(
-        'Attempting to attach an unknown Portal type. ' +
-        'BasePortalHost accepts either a ComponentPortal or a TemplatePortal.');
-  }
-}
-
 /** Exception thrown when attempting to attach a portal to a null host. */
 export class MdNullPortalHostError extends MdError {
   constructor() {

src/lib/portal/portal.ts

@@ -11,7 +11,6 @@ import {
   MdNoPortalAttachedError,
   MdNullPortalError,
   MdPortalHostAlreadyDisposedError,
-  MdUnknownPortalTypeError
 } from './portal-errors';
 import { ComponentType } from '../overlay/generic-component-type';
 
@@ -149,7 +148,7 @@ export interface PortalHost {
 
 /**
  * Partial implementation of PortalHost that only deals with attaching either a
- * ComponentPortal or a TemplatePortal.
+ * ComponentPortal
  */
 export abstract class BasePortalHost implements PortalHost {
   /** The portal currently attached to the host. */
@@ -163,10 +162,10 @@ export abstract class BasePortalHost implements PortalHost {
 
   /** Whether this host has an attached portal. */
   hasAttached() {
-    return this._attachedPortal != null;
+    return this._attachedPortal !== undefined;
   }
 
-  attach(portal: Portal<any>, newestOnTop: boolean): any {
+  attach(portal: ComponentPortal<any>, newestOnTop: boolean): any {
     if (portal == null) {
       throw new MdNullPortalError();
     }
@@ -178,28 +177,20 @@ export abstract class BasePortalHost implements PortalHost {
     if (this._isDisposed) {
       throw new MdPortalHostAlreadyDisposedError();
     }
-
-    if (portal instanceof ComponentPortal) {
-      this._attachedPortal = portal;
-      return this.attachComponentPortal(portal, newestOnTop);
-    } else if (portal instanceof TemplatePortal) {
-      this._attachedPortal = portal;
-      return this.attachTemplatePortal(portal);
-    }
-
-    throw new MdUnknownPortalTypeError();
+    this._attachedPortal = portal;
+    return this.attachComponentPortal(portal, newestOnTop);
   }
 
-  abstract attachComponentPortal<T>(portal: ComponentPortal<T>,
-    newestOnTop: boolean): ComponentRef<T>;
-
-  abstract attachTemplatePortal(portal: TemplatePortal): Map<string, any>;
+  abstract attachComponentPortal<T>(
+    portal: ComponentPortal<T>,
+    newestOnTop: boolean
+  ): ComponentRef<T>;
 
   detach(): void {
     if (this._attachedPortal) { this._attachedPortal.setAttachedHost(null); }
 
     this._attachedPortal = null;
-    if (this._disposeFn != null) {
+    if (this._disposeFn) {
       this._disposeFn();
       this._disposeFn = null;
     }