Increase test coverage

Author: denisenkom

tds.go

@@ -994,7 +994,6 @@ initiate_connection:
 	}
 
 	// processing login response
-	success := false
 	for {
 		tokchan := make(chan tokenStruct, 5)
 		go processResponse(context.Background(), &sess, tokchan, nil)
@@ -1018,7 +1017,6 @@ initiate_connection:
 					sspi_msg = nil
 				}
 			case loginAckStruct:
-				success = true
 				sess.loginAck = token
 			case error:
 				return nil, fmt.Errorf("Login error: %s", token.Error())
@@ -1036,9 +1034,6 @@ initiate_connection:
 		}
 	}
 loginEnd:
-	if !success {
-		return nil, fmt.Errorf("Login failed")
-	}
 	if sess.routedServer != "" {
 		toconn.Close()
 		p.host = sess.routedServer

tds_test.go

@@ -415,23 +415,18 @@ func TestSecureConnection(t *testing.T) {
 	}
 }
 
-func TestBadConnect(t *testing.T) {
-	checkConnStr(t)
-	SetLogger(testLogger{t})
-	connURL := makeConnStr(t)
-	connURL.User = url.UserPassword("baduser", "badpwd")
-	badDSN := connURL.String()
-
-	conn, err := sql.Open("mssql", badDSN)
-	if err != nil {
-		t.Error("Open connection failed:", err.Error())
-	}
-	defer conn.Close()
+func TestBadCredentials(t *testing.T) {
+	params := testConnParams(t)
+	params.password = "padpwd"
+	params.user = "baduser"
+	testConnectionBad(t, params.toUrl().String())
+}
 
-	err = conn.Ping()
-	if err == nil {
-		t.Error("Ping should fail for connection: ", badDSN)
-	}
+func TestBadHost(t *testing.T) {
+	params := testConnParams(t)
+	params.host = "badhost"
+	params.instance = ""
+	testConnectionBad(t, params.toUrl().String())
 }
 
 func TestSSPIAuth(t *testing.T) {