Merge pull request #266 from dblock/removed-deprecated-hooks

Removed deprecated hooks.

Author: dblock

CHANGELOG.md

@@ -1,9 +1,10 @@
 ### 0.16.0 (Next)
 
 * [#263](https://github.com/slack-ruby/slack-ruby-bot/pull/263): Removed Giphy support - [@dblock](https://github.com/dblock).
-* [#260](https://github.com/slack-ruby/slack-ruby-bot/pull/260): Add brief migration guide - [@wasabigeek](https://github.com/wasabigeek).
+* [#260](https://github.com/slack-ruby/slack-ruby-bot/pull/260): Added a brief migration guide - [@wasabigeek](https://github.com/wasabigeek).
 * [#264](https://github.com/slack-ruby/slack-ruby-bot/pull/264): Added TOC to README - [@dblock](https://github.com/dblock).
-* [#265](https://github.com/slack-ruby/slack-ruby-bot/pull/265): Make `allow_bot_messages` and `allow_message_loops` available in `SlackRubyBot::Client` - [@dblock](https://github.com/dblock).
+* [#265](https://github.com/slack-ruby/slack-ruby-bot/pull/265): Made `allow_bot_messages` and `allow_message_loops` available in `SlackRubyBot::Client` - [@dblock](https://github.com/dblock).
+* [#266](https://github.com/slack-ruby/slack-ruby-bot/pull/266): Removed deprecated `Server#hooks` - [@dblock](https://github.com/dblock).
 * Your contribution here.
 
 ### 0.15.0 (2020/5/8)

README.md

@@ -39,7 +39,6 @@ If you are not familiar with Slack bots or Slack API concepts, you might want to
       - [Hooks registration on SlackRubyBot::Server initialization](#hooks-registration-on-slackrubybotserver-initialization)
       - [Hooks registration on a SlackRubyBot::Server instance](#hooks-registration-on-a-slackrubybotserver-instance)
       - [Hooks registration on SlackRubyBot::Server class](#hooks-registration-on-slackrubybotserver-class)
-    - [Deprecated hook registration](#deprecated-hook-registration)
   - [Bot Message Protection](#bot-message-protection)
   - [Message Loop Protection](#message-loop-protection)
   - [Logging](#logging)
@@ -462,19 +461,6 @@ These will get pushed into the hook set on initialization.
 
 Either by configuration, explicit assignment or hook blocks, multiple handlers can exist for the same event type.
 
-
-#### Deprecated hook registration
-
-Registering a hook method using `hooks.add` is considered deprecated and
-will be removed on future versions.
-
-```ruby
-# [DEPRECATED]
-server.hooks.add(:hello, MyBot::Hooks::UserChange.new)
-server.hooks.add(:hello, ->(client, data) { puts "Hello!" })
-
-```
-
 ### Bot Message Protection
 
 By default bots do not respond to self or other bots. If you wish to change that behavior globally, set `allow_bot_messages` to `true`.

UPGRADING.md

@@ -9,6 +9,12 @@ GIF, Giphy and other animated GIF support has been removed. Remove `gif` options
 
 See [#261](https://github.com/slack-ruby/slack-ruby-bot/issues/261) for details.
 
+#### Removed deprecated `server.hooks`
+
+The previously deprecated `SlackRubyBot::Server#hooks` has been removed.
+
+See [#266](https://github.com/slack-ruby/slack-ruby-bot/issues/266) for details.
+
 ### Upgrading to >= 0.15.0
 
 #### Set up VCR explicitly

lib/slack-ruby-bot/hooks/hook_support.rb

@@ -18,12 +18,6 @@ def on(event_name, &block)
         end
       end
 
-      # Instance stuff
-      def hooks
-        warn Kernel.caller.first + ' [DEPRECATION] `hooks` method is deprecated. Please use `server.on` instead to register a hook.'
-        _hooks
-      end
-
       def on(event_name, handler)
         _hooks.add(event_name, handler)
       end

spec/slack-ruby-bot/hooks/hook_support_spec.rb

@@ -56,11 +56,6 @@
     end
   end
 
-  describe '#hooks' do
-    subject { super().new }
-    it { expect(subject.hooks).to eq subject.send(:_hooks) }
-  end
-
   describe '#_hooks' do
     it 'returns a SlackRubyBot::Hooks::Set instance' do
       hooks_set = subject.new.send(:_hooks)