Skip to content

Commit d3a1514

Browse files
committed
refactor(tick durations): prevent tick duration reference modification
1 parent 2ef6563 commit d3a1514

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/de/sldk/mc/metrics/TickDurationMedianCollector.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ public TickDurationMedianCollector(Plugin plugin) {
2020
}
2121

2222
private long getTickDurationMedian() {
23-
/* Copy the original array - don't want to sort it! */
24-
long[] tickTimes = collector.getTickDurations().clone();
23+
long[] tickTimes = collector.getTickDurations();
2524
Arrays.sort(tickTimes);
2625
return tickTimes[tickTimes.length / 2];
2726
}

src/main/java/de/sldk/mc/metrics/tickDuration/DefaultTickDurationStrategy.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ public DefaultTickDurationStrategy(Logger logger) {
6767
* was unable to locate the minecraft tick times buffer
6868
*/
6969
public long[] getTickDurations() {
70-
return tickDurationReference;
70+
// Return a copy of the array to prevent modification
71+
return tickDurationReference.clone();
7172
}
7273
}

0 commit comments

Comments
 (0)