Skip to content

Commit dd3cbcf

Browse files
ref: trim overly broad DeprecationWarning filters intended for escape sequences (getsentry#34242)
* ref: trim overly broad DeprecationWarning filters intended for escape sequences * ref: fix a typo to trigger tests
1 parent 09a4448 commit dd3cbcf

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

pyproject.toml

-9
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,6 @@ filterwarnings = [
3434

3535
"ignore::django.utils.deprecation.RemovedInDjango30Warning",
3636

37-
# DeprecationWarnings from Python 3.6's sre_parse are just so painful,
38-
# and I haven't found a way to ignore it specifically from a module.
39-
# This one in particular is from the "cookies" packages as depended
40-
# on by an outdated version of responses, and shows up all over tests.
41-
# TODO(joshuarli): Upgrade responses, then revisit this.
42-
# It'll probably show up in other dependencies.
43-
"ignore::DeprecationWarning",
44-
"error:Using or importing the ABCs from 'collections':DeprecationWarning",
45-
4637
# At writing, the Google Bigtable Emulator relies on deprecated behavior
4738
# internally, this can be removed once a version containing this fix is
4839
# released: https://github.com/googleapis/python-bigtable/pull/246

tests/sentry/search/events/test_builder.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1983,7 +1983,7 @@ def test_run_query(self):
19831983
)
19841984

19851985
def test_run_query_with_hour_interval(self):
1986-
# See comment on resolve_time_column for explaination of this test
1986+
# See comment on resolve_time_column for explanation of this test
19871987
self.start = datetime.datetime.now(timezone.utc).replace(
19881988
hour=15, minute=30, second=0, microsecond=0
19891989
)

0 commit comments

Comments
 (0)